html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5188#issuecomment-822812140,https://api.github.com/repos/pydata/xarray/issues/5188,822812140,MDEyOklzc3VlQ29tbWVudDgyMjgxMjE0MA==,5635139,2021-04-19T21:55:05Z,2021-04-19T21:55:05Z,MEMBER,"> that still fails, but the error is `ValueError: seek of closed file` for `f.seek(8)`
Yes! This is the error I was getting","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822686424,https://api.github.com/repos/pydata/xarray/issues/5188,822686424,MDEyOklzc3VlQ29tbWVudDgyMjY4NjQyNA==,5635139,2021-04-19T18:35:29Z,2021-04-19T18:35:29Z,MEMBER,"I'll merge this version which has most of them.
Ideally we would do all of them — otherwise people will keep using the `raises_regex` — we had that issue with the `self.assert` functions a few years ago. But we can finish it up another time.
> fix by hand the failing tests (if any) ;)
😬
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822680772,https://api.github.com/repos/pydata/xarray/issues/5188,822680772,MDEyOklzc3VlQ29tbWVudDgyMjY4MDc3Mg==,5635139,2021-04-19T18:26:25Z,2021-04-19T18:26:25Z,MEMBER,"> BTW, I think you can skip the `r`-prefix everywhere making the change even more appealing. It is only useful when using `\` operands in the the match string which is almost never the case in xarray.
Yes but not 100%! I would do another regex special to check whether it contains a `\`, but the weekend fun is over and this may have to wait until next time :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822596534,https://api.github.com/repos/pydata/xarray/issues/5188,822596534,MDEyOklzc3VlQ29tbWVudDgyMjU5NjUzNA==,5635139,2021-04-19T16:16:02Z,2021-04-19T16:16:02Z,MEMBER,"This is weird: https://github.com/pydata/xarray/pull/5188/commits/3f1d3d13326e3d871cd15bb4aad133f17de1933a
Apart from that, does anyone know a good reason to keep our own impl?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006