html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5188#issuecomment-822826570,https://api.github.com/repos/pydata/xarray/issues/5188,822826570,MDEyOklzc3VlQ29tbWVudDgyMjgyNjU3MA==,14808389,2021-04-19T22:25:02Z,2021-04-19T22:25:02Z,MEMBER,"of course, that does not explain why `raises_regex` passes","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822826163,https://api.github.com/repos/pydata/xarray/issues/5188,822826163,MDEyOklzc3VlQ29tbWVudDgyMjgyNjE2Mw==,14808389,2021-04-19T22:24:17Z,2021-04-19T22:24:17Z,MEMBER,"I'm not sure why, but `open_dataset(f, engine=""scipy"")` seems to close the file if a `TypeError` is raised: if I put
```python
print(f, f.closed)
try:
open_dataset(f, engine=""scipy"")
except TypeError:
pass
print(f, f.closed)
```
before `f.seek(0)`, the second print reports `f.closed = True` and `f.seek` fails. Is that a bug in the `scipy` engine?","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822698126,https://api.github.com/repos/pydata/xarray/issues/5188,822698126,MDEyOklzc3VlQ29tbWVudDgyMjY5ODEyNg==,14808389,2021-04-19T18:52:30Z,2021-04-19T18:53:55Z,MEMBER,"> Apart from that, does anyone know a good reason to keep our own impl?
I think our own implementation precedes the `match` parameter, so there's no reason for keeping it. I'll try to find the reason why the backends tests fail.
> This is weird: 3f1d3d1
that's because `match` is a keyword-only parameter, `*args` seems to be used only when called with a function:
```python
pytest.raises(Exc, func, match=""passed on"").match(""my pattern"")
```
Edit: that still fails, but the error is `ValueError: seek of closed file` for `f.seek(8)`","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006