html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5188#issuecomment-822826570,https://api.github.com/repos/pydata/xarray/issues/5188,822826570,MDEyOklzc3VlQ29tbWVudDgyMjgyNjU3MA==,14808389,2021-04-19T22:25:02Z,2021-04-19T22:25:02Z,MEMBER,"of course, that does not explain why `raises_regex` passes","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822826163,https://api.github.com/repos/pydata/xarray/issues/5188,822826163,MDEyOklzc3VlQ29tbWVudDgyMjgyNjE2Mw==,14808389,2021-04-19T22:24:17Z,2021-04-19T22:24:17Z,MEMBER,"I'm not sure why, but `open_dataset(f, engine=""scipy"")` seems to close the file if a `TypeError` is raised: if I put
```python
print(f, f.closed)
try:
    open_dataset(f, engine=""scipy"")
except TypeError:
    pass
print(f, f.closed)
```
before `f.seek(0)`, the second print reports `f.closed = True` and `f.seek` fails. Is that a bug in the `scipy` engine?","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822812140,https://api.github.com/repos/pydata/xarray/issues/5188,822812140,MDEyOklzc3VlQ29tbWVudDgyMjgxMjE0MA==,5635139,2021-04-19T21:55:05Z,2021-04-19T21:55:05Z,MEMBER,"> that still fails, but the error is `ValueError: seek of closed file` for `f.seek(8)`

Yes! This is the error I was getting","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822698126,https://api.github.com/repos/pydata/xarray/issues/5188,822698126,MDEyOklzc3VlQ29tbWVudDgyMjY5ODEyNg==,14808389,2021-04-19T18:52:30Z,2021-04-19T18:53:55Z,MEMBER,"> Apart from that, does anyone know a good reason to keep our own impl?

I think our own implementation precedes the `match` parameter, so there's no reason for keeping it. I'll try to find the reason why the backends tests fail.

> This is weird: 3f1d3d1

that's because `match` is a keyword-only parameter, `*args` seems to be used only when called with a function:
```python
pytest.raises(Exc, func, match=""passed on"").match(""my pattern"")
```

Edit: that still fails, but the error is `ValueError: seek of closed file` for `f.seek(8)`","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822686424,https://api.github.com/repos/pydata/xarray/issues/5188,822686424,MDEyOklzc3VlQ29tbWVudDgyMjY4NjQyNA==,5635139,2021-04-19T18:35:29Z,2021-04-19T18:35:29Z,MEMBER,"I'll merge this version which has most of them. 

Ideally we would do all of them — otherwise people will keep using the `raises_regex` — we had that issue with the `self.assert` functions a few years ago. But we can finish it up another time.

> fix by hand the failing tests (if any) ;)

😬 
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822685095,https://api.github.com/repos/pydata/xarray/issues/5188,822685095,MDEyOklzc3VlQ29tbWVudDgyMjY4NTA5NQ==,226037,2021-04-19T18:33:23Z,2021-04-19T18:34:12Z,MEMBER,"> I would do another regex special to check whether it contains a `\`

@max-sixty I was thinking to something more brutal: I would drop the `r`-prefix everywhere and fix by hand the failing tests (if any) ;)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822680772,https://api.github.com/repos/pydata/xarray/issues/5188,822680772,MDEyOklzc3VlQ29tbWVudDgyMjY4MDc3Mg==,5635139,2021-04-19T18:26:25Z,2021-04-19T18:26:25Z,MEMBER,"> BTW, I think you can skip the `r`-prefix everywhere making the change even more appealing. It is only useful when using `\` operands in the the match string which is almost never the case in xarray.

Yes but not 100%! I would do another regex special to check whether it contains a `\`, but the weekend fun is over and this may have to wait until next time :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822677989,https://api.github.com/repos/pydata/xarray/issues/5188,822677989,MDEyOklzc3VlQ29tbWVudDgyMjY3Nzk4OQ==,226037,2021-04-19T18:21:59Z,2021-04-19T18:21:59Z,MEMBER,"@max-sixty I like the cleanup even it it is rather big. I for one find it very confusing when tests use non standard helpers.

BTW, I think you can skip the `r`-prefix everywhere making the change even more appealing. It is only useful when using `\` operands in the the match string which is almost never the case in xarray.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006
https://github.com/pydata/xarray/pull/5188#issuecomment-822596534,https://api.github.com/repos/pydata/xarray/issues/5188,822596534,MDEyOklzc3VlQ29tbWVudDgyMjU5NjUzNA==,5635139,2021-04-19T16:16:02Z,2021-04-19T16:16:02Z,MEMBER,"This is weird: https://github.com/pydata/xarray/pull/5188/commits/3f1d3d13326e3d871cd15bb4aad133f17de1933a

Apart from that, does anyone know a good reason to keep our own impl?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860909006