html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5153#issuecomment-830686509,https://api.github.com/repos/pydata/xarray/issues/5153,830686509,MDEyOklzc3VlQ29tbWVudDgzMDY4NjUwOQ==,5635139,2021-05-01T20:01:27Z,2021-05-01T20:01:27Z,MEMBER,Thanks a lot @johnomotani !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,857378504
https://github.com/pydata/xarray/pull/5153#issuecomment-830637894,https://api.github.com/repos/pydata/xarray/issues/5153,830637894,MDEyOklzc3VlQ29tbWVudDgzMDYzNzg5NA==,3958036,2021-05-01T14:01:36Z,2021-05-01T14:01:36Z,CONTRIBUTOR,The vote seems to be for a separate `cumulative_integrate` method - I've made that change.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,857378504
https://github.com/pydata/xarray/pull/5153#issuecomment-826263265,https://api.github.com/repos/pydata/xarray/issues/5153,826263265,MDEyOklzc3VlQ29tbWVudDgyNjI2MzI2NQ==,1217238,2021-04-25T05:57:29Z,2021-04-25T05:57:29Z,MEMBER,"This is definitely welcome functionality! My only question is whether it should be a flag in the existing `integrate` method or a new method altogether, e.g., `cumulative_integrate`?

I would lean towards a new method because the function signature is different (not removing a dimension).","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,857378504
https://github.com/pydata/xarray/pull/5153#issuecomment-826144780,https://api.github.com/repos/pydata/xarray/issues/5153,826144780,MDEyOklzc3VlQ29tbWVudDgyNjE0NDc4MA==,5635139,2021-04-24T19:51:42Z,2021-04-24T19:51:42Z,MEMBER,Great — shall we merge?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,857378504
https://github.com/pydata/xarray/pull/5153#issuecomment-821328415,https://api.github.com/repos/pydata/xarray/issues/5153,821328415,MDEyOklzc3VlQ29tbWVudDgyMTMyODQxNQ==,5635139,2021-04-16T17:31:55Z,2021-04-16T17:31:55Z,MEMBER,"If we had a `.expanding` method (we only have `.rolling` at the moment), then I guess this could be `.expanding(dim).integrate()`. Is that right?

(but given we don't yet, no need to delay this)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,857378504
https://github.com/pydata/xarray/pull/5153#issuecomment-819140566,https://api.github.com/repos/pydata/xarray/issues/5153,819140566,MDEyOklzc3VlQ29tbWVudDgxOTE0MDU2Ng==,6815844,2021-04-14T00:41:20Z,2021-04-14T00:41:20Z,MEMBER,"> There's a cumtrapz in https://github.com/fujiisoup/xr-scipy/blob/master/xrscipy/integrate.py. Does that help?

Now most of xr-scipy functionalities are already implemented in xarray and also I couldn't take time to maintain this package.

I think basic functionalities would be better to be integrated into xarray itself and cumulative_trapezoid would be a good candidate, as `integrate` is already there.

The implementation looks good to me. 
I didn't find any edge cases where `duck_array_ops.cumulative_trapezoid` behaves differently from `scipy.integrate.cumtrapz`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,857378504
https://github.com/pydata/xarray/pull/5153#issuecomment-819120258,https://api.github.com/repos/pydata/xarray/issues/5153,819120258,MDEyOklzc3VlQ29tbWVudDgxOTEyMDI1OA==,3958036,2021-04-13T23:43:12Z,2021-04-13T23:43:12Z,CONTRIBUTOR,"> There's a cumtrapz in https://github.com/fujiisoup/xr-scipy/blob/master/xrscipy/integrate.py. Does that help?

I did a quick check and it seems like applying `scipy.integrate.cumtrapz` to a dask array returns a numpy array, whereas the `duck_array_ops.cumulative_trapezoid` that I copied from `duck_array_ops.trapz` does return a dask array (so I assume it must not force a compute?). Maybe @fujiisoup has thoughts though?

BTW the test failures are in `test_cftimeindex.py` so I assume they're unrelated to these changes.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,857378504
https://github.com/pydata/xarray/pull/5153#issuecomment-819107548,https://api.github.com/repos/pydata/xarray/issues/5153,819107548,MDEyOklzc3VlQ29tbWVudDgxOTEwNzU0OA==,2448579,2021-04-13T23:06:11Z,2021-04-13T23:06:11Z,MEMBER,There's a `cumtrapz` in https://github.com/fujiisoup/xr-scipy/blob/master/xrscipy/integrate.py. Does that help?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,857378504