html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/5101#issuecomment-831246904,https://api.github.com/repos/pydata/xarray/issues/5101,831246904,MDEyOklzc3VlQ29tbWVudDgzMTI0NjkwNA==,10194086,2021-05-03T13:05:47Z,2021-05-03T13:05:59Z,MEMBER,"Once again, thanks a lot for your contribution @johnomotani! (the test failure is unrelated)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,847489988 https://github.com/pydata/xarray/pull/5101#issuecomment-811959862,https://api.github.com/repos/pydata/xarray/issues/5101,811959862,MDEyOklzc3VlQ29tbWVudDgxMTk1OTg2Mg==,24736507,2021-04-01T14:48:03Z,2021-05-03T12:06:43Z,NONE,"Hello @johnomotani! Thanks for updating this PR. We checked the lines you've touched for [PEPĀ 8](https://www.python.org/dev/peps/pep-0008) issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: ##### Comment last updated at 2021-05-03 12:06:43 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,847489988 https://github.com/pydata/xarray/pull/5101#issuecomment-829239055,https://api.github.com/repos/pydata/xarray/issues/5101,829239055,MDEyOklzc3VlQ29tbWVudDgyOTIzOTA1NQ==,3958036,2021-04-29T13:29:55Z,2021-04-29T14:43:04Z,CONTRIBUTOR,"> One thing that could be nice is an example in http://xarray.pydata.org/en/stable/plotting.html - up to you. It seemed odd to add a `surface` example when `contour` and `countourf` weren't shown - so I've added a new subsection for 'Other types of plot' and shown all three.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,847489988 https://github.com/pydata/xarray/pull/5101#issuecomment-828034654,https://api.github.com/repos/pydata/xarray/issues/5101,828034654,MDEyOklzc3VlQ29tbWVudDgyODAzNDY1NA==,3958036,2021-04-27T23:51:19Z,2021-04-27T23:51:19Z,CONTRIBUTOR,Thanks @mathause - `master` merged now.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,847489988 https://github.com/pydata/xarray/pull/5101#issuecomment-823576115,https://api.github.com/repos/pydata/xarray/issues/5101,823576115,MDEyOklzc3VlQ29tbWVudDgyMzU3NjExNQ==,14371165,2021-04-20T20:23:30Z,2021-04-20T20:23:55Z,MEMBER,"I think you can remove all those matplotlib checks if you do something like this: ```python subplot_kws = dict() if ax is None: # TODO: Importing Axes3D is not necessary in matplotlib >= 3.2. # Remove when minimum requirement of matplotlib is 3.2: from mpl_toolkits.mplot3d import Axes3D # type: ignore # noqa subplot_kws.update(projection=""3d"") ``` I got stuck with the same thing in #4909. Importing Axes3D was the the standard way of turning on the 3d plotting functionalities. Now with newer releases it's not necessary anymore, but it's a backwards friendly way of doing it for a while longer.","{""total_count"": 2, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,847489988 https://github.com/pydata/xarray/pull/5101#issuecomment-812012953,https://api.github.com/repos/pydata/xarray/issues/5101,812012953,MDEyOklzc3VlQ29tbWVudDgxMjAxMjk1Mw==,3958036,2021-04-01T16:10:01Z,2021-04-01T16:10:01Z,CONTRIBUTOR,Tests pass! Think this is ready for review now @pydata/xarray,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,847489988 https://github.com/pydata/xarray/pull/5101#issuecomment-811935990,https://api.github.com/repos/pydata/xarray/issues/5101,811935990,MDEyOklzc3VlQ29tbWVudDgxMTkzNTk5MA==,3958036,2021-04-01T14:11:35Z,2021-04-01T14:11:35Z,CONTRIBUTOR,"Seems like the way I've implemented surface plots requires a slightly newer version than the oldest supported matplotlib to use the `""3d""` projection. matplotlib-3.2.0 basically works, but some of the unit tests require matpltolib-3.3.0 to pass. I'll try to add a check and skip some tests where necessary.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,847489988 https://github.com/pydata/xarray/pull/5101#issuecomment-811519561,https://api.github.com/repos/pydata/xarray/issues/5101,811519561,MDEyOklzc3VlQ29tbWVudDgxMTUxOTU2MQ==,3958036,2021-03-31T22:59:59Z,2021-03-31T22:59:59Z,CONTRIBUTOR,"Note, this PR includes the bugfix in #5099, because it needed to build on that change. #5099 is smaller, so I guess it will naturally be merged first.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,847489988