html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/422#issuecomment-485456780,https://api.github.com/repos/pydata/xarray/issues/422,485456780,MDEyOklzc3VlQ29tbWVudDQ4NTQ1Njc4MA==,2448579,2019-04-22T15:52:15Z,2019-04-22T15:52:15Z,MEMBER,"> With regard to the implementation, I thought of orienting myself along the lines of groupby, rolling or resample. Or are there any concerns for this specific method?

I would do the same i.e. take inspiration from the groupby / rolling / resample modules. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,84127296
https://github.com/pydata/xarray/issues/422#issuecomment-483715005,https://api.github.com/repos/pydata/xarray/issues/422,483715005,MDEyOklzc3VlQ29tbWVudDQ4MzcxNTAwNQ==,2448579,2019-04-16T15:37:37Z,2019-04-16T15:37:37Z,MEMBER,"@pgierz take a look at the ""good first issue"" label: https://github.com/pydata/xarray/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,84127296
https://github.com/pydata/xarray/issues/422#issuecomment-482737161,https://api.github.com/repos/pydata/xarray/issues/422,482737161,MDEyOklzc3VlQ29tbWVudDQ4MjczNzE2MQ==,2448579,2019-04-12T22:03:27Z,2019-04-12T22:03:27Z,MEMBER,"> I think we should maybe build in a warning that when the weights array does not contain both of the average dimensions?

hmm.. the intent here would be that the weights are broadcasted against the input array no? Not sure that a warning is required. e.g. @shoyer's comment above:

> I would suggest not using keyword arguments for `weighted`. Instead, just align based on the labels of the argument like regular xarray operations. So we'd write `da.weighted(days_per_month(da.time)).mean()`

Are we going to require that the argument to `weighted` is a `DataArray` that shares at least one dimension with `da`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,84127296