html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4974#issuecomment-1049447285,https://api.github.com/repos/pydata/xarray/issues/4974,1049447285,IC_kwDOAMm_X84-jUt1,6815844,2022-02-24T03:02:43Z,2022-02-24T03:02:43Z,MEMBER,"Hi.
Sorry for my late reply.
Well, I've just left this PR untouched.
> More specifically, the approach here (i.e., passing indexes via the pad_width argument) may be tricky in the context of flexible indexes where multiple indexes/coordinates are allowed for one dimension.
I think we can just discard this PR if this does not fit with the index refactoring.
This PR is not big anyway and maybe rewriting this functionality is faster.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,818583834
https://github.com/pydata/xarray/pull/4974#issuecomment-1047997999,https://api.github.com/repos/pydata/xarray/issues/4974,1047997999,IC_kwDOAMm_X84-dy4v,4160723,2022-02-22T16:47:01Z,2022-02-22T16:47:01Z,MEMBER,"I was wondering what is the status of this PR?
@fujiisoup do you still plan to work on it? Or maybe is it wise to wait for the indexes refactoring (#5692), i.e., https://github.com/pydata/xarray/issues/3868#issuecomment-1047947800 and revisit a bit the approach?
More specifically, the approach here (i.e., passing indexes via the `pad_width` argument) may be tricky in the context of flexible indexes where multiple indexes/coordinates are allowed for one dimension.
What about another parameter `data_values` to explicitly pass values to certain (coordinate) variables? It would accept something like `{var_name: (before_values, after_values)}` and would be passed to an `Index.pad` new method (if `var_name` is a coordinate with an index) or to `Variable.pad` as a fallback. This would keep `pad_width` simple. We'd just need to check that the arrays passed in `data_values` have dimensions matching with the dimensions of the corresponding variables and have sizes or shapes matching with the sizes specified in `pad_width`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,818583834
https://github.com/pydata/xarray/pull/4974#issuecomment-787734892,https://api.github.com/repos/pydata/xarray/issues/4974,787734892,MDEyOklzc3VlQ29tbWVudDc4NzczNDg5Mg==,24736507,2021-03-01T07:50:20Z,2021-06-29T11:56:41Z,NONE,"Hello @fujiisoup! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:
* In the file [`xarray/core/dataarray.py`](https://github.com/pydata/xarray/blob/30391c64c809686bfefd3bb878ca66eaf86016a5/xarray/core/dataarray.py):
> [Line 3954:1](https://github.com/pydata/xarray/blob/30391c64c809686bfefd3bb878ca66eaf86016a5/xarray/core/dataarray.py#L3954): [W293](https://duckduckgo.com/?q=pep8%20W293) blank line contains whitespace
##### Comment last updated at 2021-06-29 11:56:41 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,818583834
https://github.com/pydata/xarray/pull/4974#issuecomment-790021474,https://api.github.com/repos/pydata/xarray/issues/4974,790021474,MDEyOklzc3VlQ29tbWVudDc5MDAyMTQ3NA==,6815844,2021-03-03T20:08:18Z,2021-03-03T20:08:18Z,MEMBER,"Thank you @mathause for your suggestion.
This looks all the tests are passing now.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,818583834
https://github.com/pydata/xarray/pull/4974#issuecomment-789576848,https://api.github.com/repos/pydata/xarray/issues/4974,789576848,MDEyOklzc3VlQ29tbWVudDc4OTU3Njg0OA==,10194086,2021-03-03T09:36:22Z,2021-03-03T09:36:22Z,MEMBER,I think only the indentation is wrong now - e.g. https://github.com/pydata/xarray/pull/4974/checks?check_run_id=2020140730#step:8:82,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,818583834
https://github.com/pydata/xarray/pull/4974#issuecomment-789511208,https://api.github.com/repos/pydata/xarray/issues/4974,789511208,MDEyOklzc3VlQ29tbWVudDc4OTUxMTIwOA==,6815844,2021-03-03T07:44:04Z,2021-03-03T07:44:04Z,MEMBER,Not sure why the doctest is failing. The same tests in test_dataset.py do not fail...,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,818583834
https://github.com/pydata/xarray/pull/4974#issuecomment-788943018,https://api.github.com/repos/pydata/xarray/issues/4974,788943018,MDEyOklzc3VlQ29tbWVudDc4ODk0MzAxOA==,10194086,2021-03-02T14:20:59Z,2021-03-02T14:20:59Z,MEMBER,I fixed the typo (`pad_width_standardized`) but I haven't really reviewed the code... There is a doctest that fails - `da.pad(dim=1)` that should be added as test & fixed.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,818583834