html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4819#issuecomment-762816011,https://api.github.com/repos/pydata/xarray/issues/4819,762816011,MDEyOklzc3VlQ29tbWVudDc2MjgxNjAxMQ==,14808389,2021-01-19T12:40:03Z,2021-01-19T12:40:03Z,MEMBER,"I agree it's important to be consistent with `sel`. This did come as a surprise to me, though: I assumed that `sel` would only work in coordinate space, so having it switch to index space when there's no coordinate is somewhat inconsistent with that.

Also, neither `drop_sel` nor `sel` explain how they work on dimensions without coordinates in their docstrings. If we decide to keep this I think we should make sure to update the documentation.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,787692043
https://github.com/pydata/xarray/pull/4819#issuecomment-762714399,https://api.github.com/repos/pydata/xarray/issues/4819,762714399,MDEyOklzc3VlQ29tbWVudDc2MjcxNDM5OQ==,10194086,2021-01-19T09:24:14Z,2021-01-19T09:24:14Z,MEMBER,I suggested using `index = self.get_index(dim)` in  #4819. Mostly for consistency with `sel` & because there was no `drop_isel`. I don't have a strong opinion. I agree it's inconsistent - but it's also convenient and IMHO not surprising.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,787692043
https://github.com/pydata/xarray/pull/4819#issuecomment-762630904,https://api.github.com/repos/pydata/xarray/issues/4819,762630904,MDEyOklzc3VlQ29tbWVudDc2MjYzMDkwNA==,5635139,2021-01-19T06:28:36Z,2021-01-19T06:28:36Z,MEMBER,"Thanks for spotting these @keewis, sorry I missed them.

On the `sel` fallback to `isel`, though:

> I might be missing something, but I don't think `drop_sel` should work for dimensions without coordinates: `sel` as well as `drop_sel` work on labels, so they need the coordinates

I tend to agree, but `.sel` does fall back to `.isel` for dimensions without coordinates, so the now-current code is more consistent. What are your thoughts?

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,787692043
https://github.com/pydata/xarray/pull/4819#issuecomment-762471970,https://api.github.com/repos/pydata/xarray/issues/4819,762471970,MDEyOklzc3VlQ29tbWVudDc2MjQ3MTk3MA==,8579156,2021-01-18T21:11:03Z,2021-01-18T21:11:03Z,CONTRIBUTOR,"> This is excellent! Thanks @mesejo
> 
> I added a couple of minor comments.
> 
> It would be great to do this for `DataArray` too — it can be a very simple wrapper of this method.

Thanks for the feedback. I've addressed the issues.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,787692043
https://github.com/pydata/xarray/pull/4819#issuecomment-761887054,https://api.github.com/repos/pydata/xarray/issues/4819,761887054,MDEyOklzc3VlQ29tbWVudDc2MTg4NzA1NA==,10194086,2021-01-17T21:56:28Z,2021-01-17T21:56:28Z,MEMBER,"LGTM!

> It would be great to do this for DataArray too — it can be a very simple wrapper of this method.

Just to add on to this - the wrapper can be written as:

```python

class DataArray:
    ...

    def drop_isel(self, indexers=None, **indexers_kwargs):
        """"""Drop index positions from this dataset.
        ...
        """"""
        dataset = self._to_temp_dataset()
        dataset = dataset.drop_isel(indexers=indexers, **indexers_kwargs)
        return self._from_temp_dataset(dataset)

    ...

```

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,787692043