html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/4645#issuecomment-748538603,https://api.github.com/repos/pydata/xarray/issues/4645,748538603,MDEyOklzc3VlQ29tbWVudDc0ODUzODYwMw==,10194086,2020-12-19T23:20:26Z,2020-12-19T23:20:26Z,MEMBER,Thanks @raybellwaves! ,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,755626157 https://github.com/pydata/xarray/pull/4645#issuecomment-744501356,https://api.github.com/repos/pydata/xarray/issues/4645,744501356,MDEyOklzc3VlQ29tbWVudDc0NDUwMTM1Ng==,24736507,2020-12-14T15:05:36Z,2020-12-19T21:37:51Z,NONE,"Hello @raybellwaves! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: ##### Comment last updated at 2020-12-19 21:37:51 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,755626157 https://github.com/pydata/xarray/pull/4645#issuecomment-745344959,https://api.github.com/repos/pydata/xarray/issues/4645,745344959,MDEyOklzc3VlQ29tbWVudDc0NTM0NDk1OQ==,2448579,2020-12-15T14:54:57Z,2020-12-15T14:54:57Z,MEMBER,I think you replace all `int32` by `int64`?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,755626157 https://github.com/pydata/xarray/pull/4645#issuecomment-745343820,https://api.github.com/repos/pydata/xarray/issues/4645,745343820,MDEyOklzc3VlQ29tbWVudDc0NTM0MzgyMA==,17162724,2020-12-15T14:53:09Z,2020-12-15T14:53:09Z,CONTRIBUTOR,"Not sure if I can do anything for the doctest failing https://dev.azure.com/xarray/xarray/_build/results?buildId=4491&view=logs&j=e1da92ae-4a54-5c20-3ee1-ef7b06ffcd80&t=5640f7da-bb07-517b-ec85-0b3cfe0ccaa3&l=62 ``` - * y (y) int32 10 20 30 + * y (y) int64 10 20 30 ``` ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,755626157 https://github.com/pydata/xarray/pull/4645#issuecomment-744712191,https://api.github.com/repos/pydata/xarray/issues/4645,744712191,MDEyOklzc3VlQ29tbWVudDc0NDcxMjE5MQ==,14808389,2020-12-14T21:09:49Z,2020-12-14T21:11:51Z,MEMBER,"sorry about that. I meant that the code examples still show the results using the randomly generated data, and this is the reason why the `doctests` CI fails. For example, this: https://github.com/pydata/xarray/blob/4c8642560679c173c2968a2c4186a474bfe97f2d/xarray/core/concat.py#L178-L185 should be: ```python >>> xr.concat([da.isel(y=slice(0, 1)), da.isel(y=slice(1, None))], dim=""y"") array([[0, 1, 2], [3, 4, 5]]) Coordinates: * x (x) Hopefully it's fine as is. no worries, as I said that's optional, we currently don't enforce the tool I had in mind for PRs. I can fix that in a different PR (or this one, if you don't mind me pushing to your branch).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,755626157 https://github.com/pydata/xarray/pull/4645#issuecomment-744504122,https://api.github.com/repos/pydata/xarray/issues/4645,744504122,MDEyOklzc3VlQ29tbWVudDc0NDUwNDEyMg==,17162724,2020-12-14T15:09:41Z,2020-12-14T15:09:41Z,CONTRIBUTOR,"> I would also run `pre-commit run --files doc/combining.rst xarray/core/concat.py` once, but that's optional. I'm doing this PR in my windows machine unfortunately, and pre-commit is a pain on windows. Hopefully it's fine as is.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,755626157 https://github.com/pydata/xarray/pull/4645#issuecomment-742916022,https://api.github.com/repos/pydata/xarray/issues/4645,742916022,MDEyOklzc3VlQ29tbWVudDc0MjkxNjAyMg==,2448579,2020-12-11T02:02:44Z,2020-12-11T02:02:44Z,MEMBER,"Oops one more ``` >>>------------------------------------------------------------------------- Exception in /home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/4645/doc/combining.rst at block ending on line 191 Specify :okexcept: as an option in the ipython:: block to suppress this message --------------------------------------------------------------------------- NameError Traceback (most recent call last) in ----> 1 arr.equals(arr.copy()) NameError: name 'arr' is not defined <<<------------------------------------------------------------------------- ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,755626157 https://github.com/pydata/xarray/pull/4645#issuecomment-739970397,https://api.github.com/repos/pydata/xarray/issues/4645,739970397,MDEyOklzc3VlQ29tbWVudDczOTk3MDM5Nw==,2448579,2020-12-07T14:57:46Z,2020-12-07T14:57:46Z,MEMBER,"Thanks @raybellwaves. Can you address this error? ``` >>>------------------------------------------------------------------------- Exception in /home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/4645/doc/combining.rst at block ending on line 121 Specify :okexcept: as an option in the ipython:: block to suppress this message --------------------------------------------------------------------------- NameError Traceback (most recent call last) in ----> 1 xr.Dataset({""a"": arr[:-1], ""b"": arr[1:]}) NameError: name 'arr' is not defined <<<------------------------------------------------------------------------- ``` ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,755626157 https://github.com/pydata/xarray/pull/4645#issuecomment-737616528,https://api.github.com/repos/pydata/xarray/issues/4645,737616528,MDEyOklzc3VlQ29tbWVudDczNzYxNjUyOA==,17162724,2020-12-03T02:16:43Z,2020-12-03T02:16:43Z,CONTRIBUTOR,"Thanks for the feedback. It was a copy-paste from http://xarray.pydata.org/en/stable/combining.html#concatenate I'll implement your suggestions in https://github.com/pydata/xarray/blob/master/doc/combining.rst as well. i.e. use arange for the creation and isel for the index.","{""total_count"": 2, ""+1"": 1, ""-1"": 0, ""laugh"": 1, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,755626157