html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/4634#issuecomment-736768644,https://api.github.com/repos/pydata/xarray/issues/4634,736768644,MDEyOklzc3VlQ29tbWVudDczNjc2ODY0NA==,868027,2020-12-01T19:29:36Z,2020-12-01T19:29:36Z,CONTRIBUTOR,"@dcherian Often I find it a little easier to understand the [Conformance Document](http://cfconventions.org/Data/cf-documents/requirements-recommendations/conformance-1.8.html#units), bullet point two says:
>The type of the units attribute is a string that must be recognizable by the udunits package. Exceptions are the units level, layer, and sigma_level.

This shouldn't prevent xarray from doing something useful with non conforming files if it can.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,754413100
https://github.com/pydata/xarray/issues/4634#issuecomment-736756279,https://api.github.com/repos/pydata/xarray/issues/4634,736756279,MDEyOklzc3VlQ29tbWVudDczNjc1NjI3OQ==,2448579,2020-12-01T19:05:25Z,2020-12-01T19:05:51Z,MEMBER,"Hmmm... but see http://cfconventions.org/Data/cf-conventions/cf-conventions-1.8/cf-conventions.html#units

```
 The conforming unit for quantities that represent fractions, or parts of a whole, is ""1"". 
```

EDIT: Oh I see it's the string `""1""`, not the integer `1`
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,754413100
https://github.com/pydata/xarray/issues/4634#issuecomment-736609280,https://api.github.com/repos/pydata/xarray/issues/4634,736609280,MDEyOklzc3VlQ29tbWVudDczNjYwOTI4MA==,868027,2020-12-01T15:02:22Z,2020-12-01T15:02:22Z,CONTRIBUTOR,"Keep in mind that the [NetCDF user guide](https://www.unidata.ucar.edu/software/netcdf/docs/attribute_conventions.html) ""strongly recommends"" that units be a character string. The [CF Conventions](http://cfconventions.org/Data/cf-conventions/cf-conventions-1.8/cf-conventions.html#attribute-appendix) requires the units to be a character string. I think in xarray you can set `decode_cf=False` or `decode_times=False` in the various `open_*` methods to turn off this interpretation if you need things to work right now.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,754413100
https://github.com/pydata/xarray/issues/4634#issuecomment-736597293,https://api.github.com/repos/pydata/xarray/issues/4634,736597293,MDEyOklzc3VlQ29tbWVudDczNjU5NzI5Mw==,5472566,2020-12-01T14:46:33Z,2020-12-01T14:46:33Z,NONE,I have an NC file lying around so I can easily test it. I will send a PR in coming days.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,754413100
https://github.com/pydata/xarray/issues/4634#issuecomment-736594307,https://api.github.com/repos/pydata/xarray/issues/4634,736594307,MDEyOklzc3VlQ29tbWVudDczNjU5NDMwNw==,10194086,2020-12-01T14:41:42Z,2020-12-01T14:41:42Z,MEMBER,"Yes, that could probably be updated to 

```diff
- has_date_units = ""units"" in attrs and ""since"" in attrs[""units""]
+ has_date_units = ""units"" in attrs and and isinstance(attrs[""units""], str) and ""since"" in attrs[""units""]
```

are you interested to send in a PR?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,754413100