html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/4541#issuecomment-716937842,https://api.github.com/repos/pydata/xarray/issues/4541,716937842,MDEyOklzc3VlQ29tbWVudDcxNjkzNzg0Mg==,5635139,2020-10-27T02:29:59Z,2020-10-27T06:15:51Z,MEMBER,"If it leads to incorrect results, I agree. If it leads to a lazy error (even if more confusing), or a result array full of NaNs, then I think it's fine. Not super confident on the latter case, tbc.

If we want more control, I would advocate for using a standard kwarg that offers control over the computation — e.g. `skip_na` often gives more performance in exchange for (edit: the user) ensuring no `NaN`s — rather than an idiosyncratic kwarg that's derived by the internals of this implementation","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,729980097
https://github.com/pydata/xarray/issues/4541#issuecomment-716928594,https://api.github.com/repos/pydata/xarray/issues/4541,716928594,MDEyOklzc3VlQ29tbWVudDcxNjkyODU5NA==,5635139,2020-10-27T02:00:40Z,2020-10-27T02:00:40Z,MEMBER,"> Sorry if my initial issue was unclear.

Not at all, my mistake

> So you favor not having a 'skip' kwarg to just internally skipping the call to `.any()` if `weights` is a dask array?

👍 
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,729980097
https://github.com/pydata/xarray/issues/4541#issuecomment-716913449,https://api.github.com/repos/pydata/xarray/issues/4541,716913449,MDEyOklzc3VlQ29tbWVudDcxNjkxMzQ0OQ==,5635139,2020-10-27T01:13:04Z,2020-10-27T01:13:04Z,MEMBER,"Sorry, I completely misunderstood! I thought you were asking about skipping tests as in pytest, hence my confusion.

For sure re skipping those checks with dask arrays.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,729980097
https://github.com/pydata/xarray/issues/4541#issuecomment-716908428,https://api.github.com/repos/pydata/xarray/issues/4541,716908428,MDEyOklzc3VlQ29tbWVudDcxNjkwODQyOA==,5635139,2020-10-27T00:57:04Z,2020-10-27T01:10:30Z,MEMBER,"I don't have that much context on `xgcm` so others may know better on this.

~Could you help me understand in what context you're running the tests?~

~IIRC we used to have [`--skip-slow` here](https://github.com/pydata/xarray/blob/master/conftest.py#L16), but it wasn't used that much and so is no longer there. It's definitely possible to add that sort of flag.~","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,729980097