html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/4541#issuecomment-717343483,https://api.github.com/repos/pydata/xarray/issues/4541,717343483,MDEyOklzc3VlQ29tbWVudDcxNzM0MzQ4Mw==,2448579,2020-10-27T15:57:50Z,2020-10-27T15:57:50Z,MEMBER,Another option would be to put the check in a `.map_blocks` call for dask arrays. This would only run and raise at compute time.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,729980097
https://github.com/pydata/xarray/issues/4541#issuecomment-717342942,https://api.github.com/repos/pydata/xarray/issues/4541,717342942,MDEyOklzc3VlQ29tbWVudDcxNzM0Mjk0Mg==,2448579,2020-10-27T15:57:03Z,2020-10-27T15:57:03Z,MEMBER,"> The discussion goes back to here: #2922 (comment) (by @dcherian)

Ah, sorry! I was thinking of weights as being numpy arrays, not so much dask arrays.

> Do you do something between w = data.weighted(weights) and w.mean()?

Yeah I think this is the issue. `.weighted` should be lazy.

> Thinking a bit more about this I now favour the isnull().any() test and would add a check_weights kwargs.

This would be OK. We could also drop the check and let users deal with it, and also add a warning to the docstring.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,729980097
https://github.com/pydata/xarray/issues/4541#issuecomment-716910761,https://api.github.com/repos/pydata/xarray/issues/4541,716910761,MDEyOklzc3VlQ29tbWVudDcxNjkxMDc2MQ==,2448579,2020-10-27T01:04:14Z,2020-10-27T01:04:22Z,MEMBER,The relevant context is that `.any()` will trigger computation on a dask array. Maybe we skip the check using `is_duck_dask_array`?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,729980097