html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4534#issuecomment-729552267,https://api.github.com/repos/pydata/xarray/issues/4534,729552267,MDEyOklzc3VlQ29tbWVudDcyOTU1MjI2Nw==,10194086,2020-11-18T09:28:53Z,2020-11-18T09:28:53Z,MEMBER,"Thanks! I moved
```rst
DataArray.dt.weekofyear
DataArray.dt.week
```
to `Deprecated / Pending Deprecation` in `api.rst`. I'll merge tomorrow.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728888328
https://github.com/pydata/xarray/pull/4534#issuecomment-720164789,https://api.github.com/repos/pydata/xarray/issues/4534,720164789,MDEyOklzc3VlQ29tbWVudDcyMDE2NDc4OQ==,10194086,2020-11-01T22:55:28Z,2020-11-01T22:55:28Z,MEMBER,It seems to work after merging master: https://xray--4534.org.readthedocs.build/en/4534/whats-new.html,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728888328
https://github.com/pydata/xarray/pull/4534#issuecomment-720156284,https://api.github.com/repos/pydata/xarray/issues/4534,720156284,MDEyOklzc3VlQ29tbWVudDcyMDE1NjI4NA==,10194086,2020-11-01T21:42:53Z,2020-11-01T21:42:53Z,MEMBER,"Thanks for the hints @keewis! Unfortunately I wasn't really successful in building the docs locally. `isocalendar` throws a warning but it worked on RDT. Not sure what goes wrong locally. I'll try to figure this out another time, maybe something has the wrong version.
Thus, I `isocalendar` was not in `objects.inv`, but I think `attr` and `meth` should be correct.
**Warnings**
`WARNING: [autosummary] failed to import 'xarray.DataArray.dt.isocalendar': no module named xarray.DataArray.dt.isocalendar` and
`WARNING: [autosummary] failed to import 'xarray.core.accessor_dt.DatetimeAccessor.isocalendar': no module named xarray.core.accessor_dt.DatetimeAccessor.isocalendar`
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728888328
https://github.com/pydata/xarray/pull/4534#issuecomment-720145456,https://api.github.com/repos/pydata/xarray/issues/4534,720145456,MDEyOklzc3VlQ29tbWVudDcyMDE0NTQ1Ng==,10194086,2020-11-01T20:18:58Z,2020-11-01T21:31:04Z,MEMBER,"Ok, this should work. Two open questions
1. It's `dt.isocalendar().day` in pandas but its actually the weekday. I very much prefer `dt.isocalendar().weekday`. Are we ok with deviating from pandas?
2. Should we deprecate `week` and `weekofyear` as pandas does? It's easier to do `dt.week` than `dt.isocalendar().week`. But `dt.week` might be ambiguous. (I added the deprecation but I am fine either way). TODO: move them to the deprecated api section.
3. ~Would be good if someone could double-check the `:py:attr:` in whats-new (should it be `:py:meth:`?).~ I think this should be correct now.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728888328
https://github.com/pydata/xarray/pull/4534#issuecomment-719988824,https://api.github.com/repos/pydata/xarray/issues/4534,719988824,MDEyOklzc3VlQ29tbWVudDcxOTk4ODgyNA==,10194086,2020-10-31T21:10:41Z,2020-10-31T21:10:41Z,MEMBER,"Turns out `times.isocalendar().year != times.year`.... https://en.wikipedia.org/wiki/ISO_week_date
Check:
```python
import pandas as pd
times = pd.date_range(start=""2000/01/01"", freq=""H"", periods=100)
times.isocalendar().year
```
so I guess we need this second code path...
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728888328
https://github.com/pydata/xarray/pull/4534#issuecomment-719810471,https://api.github.com/repos/pydata/xarray/issues/4534,719810471,MDEyOklzc3VlQ29tbWVudDcxOTgxMDQ3MQ==,10194086,2020-10-30T21:34:24Z,2020-10-30T21:50:43Z,MEMBER,"> I think `day` and `year` are still available in the pandas implementation though? It's only week that's going
True, I missed that.
> I'd be very happy for someone else to take this on...
I hope I understood this correctly & you don't mind me pushing to your branch.
See the code for my suggestion (tests still missing). I think we need to return a `Dataset` for `isocalendar`. The way it's done is a bit inefficient (`year` and `day` is computed twice) but we avoid a second code-path. I don't have a strong opinion on deprecating `time.dt.week` or not.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728888328
https://github.com/pydata/xarray/pull/4534#issuecomment-719785555,https://api.github.com/repos/pydata/xarray/issues/4534,719785555,MDEyOklzc3VlQ29tbWVudDcxOTc4NTU1NQ==,10194086,2020-10-30T20:37:37Z,2020-10-30T20:37:37Z,MEMBER,`CFTime` defines `day` and `year` and I think it does not make sense if these have to be accessed through `isocalendar()`,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728888328
https://github.com/pydata/xarray/pull/4534#issuecomment-716137994,https://api.github.com/repos/pydata/xarray/issues/4534,716137994,MDEyOklzc3VlQ29tbWVudDcxNjEzNzk5NA==,10194086,2020-10-25T12:12:41Z,2020-10-25T12:12:41Z,MEMBER,Do you think we should keep supporting `week` & `weekofyear`? (using isocalendar under the hood) ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728888328