html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4382#issuecomment-687356880,https://api.github.com/repos/pydata/xarray/issues/4382,687356880,MDEyOklzc3VlQ29tbWVudDY4NzM1Njg4MA==,2448579,2020-09-04T20:08:06Z,2020-09-04T20:08:06Z,MEMBER,test failure is unrelated. Thanks @astropenguin . ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,687035568
https://github.com/pydata/xarray/pull/4382#issuecomment-681900756,https://api.github.com/repos/pydata/xarray/issues/4382,681900756,MDEyOklzc3VlQ29tbWVudDY4MTkwMDc1Ng==,1197350,2020-08-27T11:53:14Z,2020-08-27T11:53:14Z,MEMBER,"Thanks for sharing this cool package! Looks vey useful. Definitely something we can list in ""related projects"". 😄 

> We have a concern: This package **directly** adds some methods to `xarray.DataArray` by using [the accessor feature](https://xarray.pydata.org/en/stable/internals.html#extending-xarray).
> For example, `dataarray.isbetween()` is implemented by registering an accessor whose name is `'isbetween'`.
> This usage may not be what is expected by the xarray's developers.

Indeed, we should probably discourage this sort of ""accessor hacking"". Just out of curiosity, why did you opt for this rather than the more standard, `dataarray.compare.isbetween()`? I see your package was just released. Are you firmly committed to your API? Or could you consider deprecating it in favor of the recommended approach in a future release?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,687035568