html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/4290#issuecomment-666378592,https://api.github.com/repos/pydata/xarray/issues/4290,666378592,MDEyOklzc3VlQ29tbWVudDY2NjM3ODU5Mg==,14808389,2020-07-30T13:53:25Z,2020-07-30T13:53:25Z,MEMBER,"I'm not sure if that's something we want to do: what happens if the dataset has more than one variable? I guess what we're talking about here is making `bool(ds)` a alias of `all(ds.values() or [False])` (the `... or [False]` is for making `Dataset({})` return `False` instead of `True`). Thoughts, @pydata/xarray?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,668717850 https://github.com/pydata/xarray/issues/4290#issuecomment-666366366,https://api.github.com/repos/pydata/xarray/issues/4290,666366366,MDEyOklzc3VlQ29tbWVudDY2NjM2NjM2Ng==,14808389,2020-07-30T13:31:38Z,2020-07-30T13:31:38Z,MEMBER,"If I remember correctly, `Dataset` inherits from `dict` and doesn't define it's own `__bool__`, so it has the behavior of `dict.__bool__`: ```python In [2]: bool(xr.Dataset()) Out[2]: False In [3]: bool(xr.Dataset({""x"": False})) Out[3]: True In [4]: bool({}) Out[4]: False In [5]: bool({""x"": False}) Out[5]: True ```","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,668717850