html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4237#issuecomment-679393627,https://api.github.com/repos/pydata/xarray/issues/4237,679393627,MDEyOklzc3VlQ29tbWVudDY3OTM5MzYyNw==,14808389,2020-08-24T22:14:27Z,2020-08-24T22:14:27Z,MEMBER,I'll add one in one of the follow-up PRs,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211
https://github.com/pydata/xarray/pull/4237#issuecomment-679392235,https://api.github.com/repos/pydata/xarray/issues/4237,679392235,MDEyOklzc3VlQ29tbWVudDY3OTM5MjIzNQ==,2448579,2020-08-24T22:10:41Z,2020-08-24T22:10:41Z,MEMBER,oops this is missing a whats-new entry.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211
https://github.com/pydata/xarray/pull/4237#issuecomment-679217623,https://api.github.com/repos/pydata/xarray/issues/4237,679217623,MDEyOklzc3VlQ29tbWVudDY3OTIxNzYyMw==,14808389,2020-08-24T16:03:38Z,2020-08-24T22:04:15Z,MEMBER,":+1:. I tried modifying `fillna`, but that turned out to be harder than I expected.

As a summary, per-variable fill values for `fillna` and `where` are still left for other PRs.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211
https://github.com/pydata/xarray/pull/4237#issuecomment-679389389,https://api.github.com/repos/pydata/xarray/issues/4237,679389389,MDEyOklzc3VlQ29tbWVudDY3OTM4OTM4OQ==,2448579,2020-08-24T22:03:09Z,2020-08-24T22:03:09Z,MEMBER,Thanks @keewis,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211
https://github.com/pydata/xarray/pull/4237#issuecomment-679215227,https://api.github.com/repos/pydata/xarray/issues/4237,679215227,MDEyOklzc3VlQ29tbWVudDY3OTIxNTIyNw==,2448579,2020-08-24T15:59:40Z,2020-08-24T15:59:40Z,MEMBER,shall we merge and leave the rest to future PRs?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211
https://github.com/pydata/xarray/pull/4237#issuecomment-677832593,https://api.github.com/repos/pydata/xarray/issues/4237,677832593,MDEyOklzc3VlQ29tbWVudDY3NzgzMjU5Mw==,2448579,2020-08-20T18:40:33Z,2020-08-20T18:40:33Z,MEMBER,Ya I can't think of a better way than looping through the variables.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211
https://github.com/pydata/xarray/pull/4237#issuecomment-676547072,https://api.github.com/repos/pydata/xarray/issues/4237,676547072,MDEyOklzc3VlQ29tbWVudDY3NjU0NzA3Mg==,14808389,2020-08-19T17:02:55Z,2020-08-20T00:29:01Z,MEMBER,"does anyone have any advice on how to add multiple fill value support to `fillna`? It is currently using `ops.fillna` which uses `apply_ufunc` with `duck_array_ops.fillna`: https://github.com/pydata/xarray/blob/d9ebcafaddf0bb80052d30f43ca5ea18a5c7229f/xarray/core/ops.py#L137-L171 but that obviously only works for data variables.

To fix that, I *would* manually apply `duck_array_ops.fillna` to data variables and coordinates and then reassemble the dataset (using `_to_temp_dataset` / `_from_temp_dataset` for `DataArray`), but since I don't really understand `apply_ufunc` I'm not sure what that would break.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211
https://github.com/pydata/xarray/pull/4237#issuecomment-676632785,https://api.github.com/repos/pydata/xarray/issues/4237,676632785,MDEyOklzc3VlQ29tbWVudDY3NjYzMjc4NQ==,1217238,2020-08-19T20:02:23Z,2020-08-19T20:02:23Z,MEMBER,"> To fix that, I _would_ manually apply `duck_array_ops.fillna` to data variables and coordinates and then reassemble the dataset (using `_to_temp_dataset` / `_from_temp_dataset` for `DataArray`), but since I don't really understand `apply_ufunc`, I'm not sure what that would break.

I think this would be a fine way to it, though it does feel rather complicated. Per variable fill-values doesn't quite fit the model of `apply_ufunc` when applied to entire Dataset/DataArray objects.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211
https://github.com/pydata/xarray/pull/4237#issuecomment-663023181,https://api.github.com/repos/pydata/xarray/issues/4237,663023181,MDEyOklzc3VlQ29tbWVudDY2MzAyMzE4MQ==,14808389,2020-07-23T13:58:43Z,2020-08-05T09:37:21Z,MEMBER,"Here's the list of functions I'm considering to extend:
* [x] concat / merge / align / combine_* (but aligning `DataArray` objects and `combine_by_coords` have no tests for different fill values)
* [ ] apply_ufunc (?)
* [x] full_like (for `Dataset` args)
* [x] Dataset.reindex / Dataset.reindex_like
* [x] DataArray.reindex / DataArray.reindex_like (for non-dimension coordinates)
* [x] Dataset.unstack
* [x] DataArray.unstack (works since it delegates to `Dataset.unstack`, but doesn't have tests)
* [x] Dataset.merge
* [x] Dataset.shift
* [ ] ~DataArray.shift (probably doesn't make sense, though)~
* [ ] Dataset.pad (already works)
* [ ] DataArray.pad (already works)
* [ ] Dataset.idxmin / Dataset.idxmax: uses `Dataset.map` and is quite difficult to extend
* [ ] ~DataArray.idxmin / DataArray.idxmax~: doesn't make much sense, I think
* [ ] Dataset.fillna (already works for data variables, but difficult to extend to coordinates)
* [ ] DataArray.fillna
* [ ] ~Dataset.rolling.construct (not sure if that makes sense)~
* [ ] ~Dataset.interp / DataArray.interp (for extrapolation, using the `kwargs` parameter): we probably shouldn't support this, but instead recommend `ds.interp(...).fillna({""a"": ..., ""b"": ...})`.~","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211
https://github.com/pydata/xarray/pull/4237#issuecomment-663778598,https://api.github.com/repos/pydata/xarray/issues/4237,663778598,MDEyOklzc3VlQ29tbWVudDY2Mzc3ODU5OA==,14808389,2020-07-25T00:03:11Z,2020-07-25T00:03:11Z,MEMBER,"`apply_ufunc` turns out to be way too complicated for me to change it without understanding most of the code, so I guess we should postpone that until someone needs multiple fill values on dataset objects?

I think `fillna` should allow filling coordinates (both dimension and non-dimension coordinates), but the current implementation simply uses `apply_ufunc` with `duck_array_ops.fillna`, so I'm not sure how to support that.

Same for `idxmin` and `idxmax`: they use `Dataset.map` or call the computation function directly, so we'd need to rewrite those functions to get fill values.


","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211
https://github.com/pydata/xarray/pull/4237#issuecomment-663070464,https://api.github.com/repos/pydata/xarray/issues/4237,663070464,MDEyOklzc3VlQ29tbWVudDY2MzA3MDQ2NA==,14808389,2020-07-23T15:24:19Z,2020-07-23T15:24:19Z,MEMBER,"1. me neither, that's why I added the question mark (I'll investigate a bit more)
2. agreed
3. yep, the docs say:
  > Only data variables are moved; coordinates stay in place. This is consistent with the behavior of ``shift`` in pandas.

   and the code doesn't touch the coordinates (not even non-dimension coordinates). ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211
https://github.com/pydata/xarray/pull/4237#issuecomment-663064403,https://api.github.com/repos/pydata/xarray/issues/4237,663064403,MDEyOklzc3VlQ29tbWVudDY2MzA2NDQwMw==,2448579,2020-07-23T15:13:11Z,2020-07-23T15:13:11Z,MEMBER,"1. I am unsure about `apply_ufunc`
2. I think we can safely avoid `interp` and `rolling.construct` . It is easy to add a `.fillna` call
3. Does `shift` not shift non-dimensional coordinates? If not, then I agree it doesn't make sense.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211
https://github.com/pydata/xarray/pull/4237#issuecomment-660357715,https://api.github.com/repos/pydata/xarray/issues/4237,660357715,MDEyOklzc3VlQ29tbWVudDY2MDM1NzcxNQ==,14808389,2020-07-17T22:08:31Z,2020-07-17T22:08:31Z,MEMBER,"> Should we add more tests for higher level functions

I have been focusing on functions that use `reindex`, but I agree that others like `fillna` / `bfill` / `ffill` and `unstack` should allow mappings, too.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,659232211