html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4221#issuecomment-682427800,https://api.github.com/repos/pydata/xarray/issues/4221,682427800,MDEyOklzc3VlQ29tbWVudDY4MjQyNzgwMA==,14808389,2020-08-28T09:30:14Z,2020-08-28T09:30:14Z,MEMBER,"you mean the commit message? If so, you can use `git commit --amend` to change it (make sure you don't have anything staged because that would be added to the commit) and force-push. It's not that important, though, I doubt anyone really reads the commit messages.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,656163384
https://github.com/pydata/xarray/pull/4221#issuecomment-681982126,https://api.github.com/repos/pydata/xarray/issues/4221,681982126,MDEyOklzc3VlQ29tbWVudDY4MTk4MjEyNg==,14808389,2020-08-27T14:24:14Z,2020-08-27T14:24:14Z,MEMBER,"we went with https://github.com/pydata/xarray/blob/edd5c1e96204d59d30496e3f85e2f805a911ac9b/xarray/core/variable.py#L938 in #4379, you could use something like that here: https://github.com/pydata/xarray/blob/3337b6fc4024dcaa2c11831e6d34551adaee4a8b/xarray/core/formatting.py#L554 too, e.g. with:
```python
def is_duck_array_or_ndarray(array):
    return is_duck_array(array) or (not IS_NEP18_ACTIVE and isinstance(data, np.ndarray))
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,656163384
https://github.com/pydata/xarray/pull/4221#issuecomment-681188808,https://api.github.com/repos/pydata/xarray/issues/4221,681188808,MDEyOklzc3VlQ29tbWVudDY4MTE4ODgwOA==,14808389,2020-08-27T00:17:12Z,2020-08-27T00:23:49Z,MEMBER,"yes, the failing test is definitely due to NEP18: there's a numpy array in an attribute, but since numpy 1.15 doesn't define `__array_function__`, `is_duck_array` returns `False`. We could extend `is_duck_array` with an `isinstance` check for `numpy.ndarray`, or we could take your suggestion and `xfail` the test. Not sure which is better.

`black` recently released a new version, which changed the way it treats a trailing comma, and it also reformats docstrings (at least as much as it can without breaking formats), but neither `conda` nor the `pre-commit` hook install the new version (yet). To make the diff of this PR as small as possible, I'm opening a new PR with just the automatic changes, once that is merged, it should be fixed by merging in `master`.

Edit: see #4381","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,656163384
https://github.com/pydata/xarray/pull/4221#issuecomment-658130892,https://api.github.com/repos/pydata/xarray/issues/4221,658130892,MDEyOklzc3VlQ29tbWVudDY1ODEzMDg5Mg==,14808389,2020-07-14T11:37:23Z,2020-07-14T11:37:23Z,MEMBER,"Revisiting it I now realize that `is_array_like` is actually not a good name for that function: officially, ""array_like"" means that it can be casted using `np.asarray`. Maybe we should rename that to `is_duck_array`? But then we'd also need to check for `__array_ufunc__` and `__array_function__` because we also need those to properly wrap duck arrays.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,656163384