html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/4221#issuecomment-681411776,https://api.github.com/repos/pydata/xarray/issues/4221,681411776,MDEyOklzc3VlQ29tbWVudDY4MTQxMTc3Ng==,1217238,2020-08-27T04:37:29Z,2020-08-27T04:37:29Z,MEMBER,"> yes, the failing test is definitely due to NEP18: there's a numpy array in an attribute, but since numpy 1.15 doesn't define `__array_function__`, `is_duck_array` returns `False`. We could extend `is_duck_array` with an `isinstance` check for `numpy.ndarray`, or we could take your suggestion and `xfail` the test. Not sure which is better. I would suggest adding an explicit check for NumPy arrays. Otherwise we would need to bump our minimum supported NumPy version. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,656163384