html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4018#issuecomment-631608640,https://api.github.com/repos/pydata/xarray/issues/4018,631608640,MDEyOklzc3VlQ29tbWVudDYzMTYwODY0MA==,1700203,2020-05-20T17:13:21Z,2020-05-20T17:13:21Z,CONTRIBUTOR,"Thanks, @dcherian! I'm happy to contribute 😊 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,610687463
https://github.com/pydata/xarray/pull/4018#issuecomment-631606013,https://api.github.com/repos/pydata/xarray/issues/4018,631606013,MDEyOklzc3VlQ29tbWVudDYzMTYwNjAxMw==,2448579,2020-05-20T17:08:18Z,2020-05-20T17:08:18Z,MEMBER,Yay. Thanks @blsqr. I see this is your first PR. welcome!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,610687463
https://github.com/pydata/xarray/pull/4018#issuecomment-625890207,https://api.github.com/repos/pydata/xarray/issues/4018,625890207,MDEyOklzc3VlQ29tbWVudDYyNTg5MDIwNw==,2448579,2020-05-08T16:09:46Z,2020-05-08T16:09:46Z,MEMBER,LGTM. Thanks @blsqr ,"{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,610687463
https://github.com/pydata/xarray/pull/4018#issuecomment-622965234,https://api.github.com/repos/pydata/xarray/issues/4018,622965234,MDEyOklzc3VlQ29tbWVudDYyMjk2NTIzNA==,1700203,2020-05-02T14:47:54Z,2020-05-02T14:47:54Z,CONTRIBUTOR,"Alright, I added the test. From my side, this would be ready. :)

Let me know if further changes to the tests or What's New are necessary.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,610687463
https://github.com/pydata/xarray/pull/4018#issuecomment-622468368,https://api.github.com/repos/pydata/xarray/issues/4018,622468368,MDEyOklzc3VlQ29tbWVudDYyMjQ2ODM2OA==,2448579,2020-05-01T16:53:15Z,2020-05-01T16:53:15Z,MEMBER,"If you are up for it, we'd love to add testing for that error in this PR.

 I think `NetCDF3Only` is the right place to put it. It gets called by a number of test classes that inherit from `NetCDF3Only`. Add it there and see if things pass?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,610687463
https://github.com/pydata/xarray/pull/4018#issuecomment-622389439,https://api.github.com/repos/pydata/xarray/issues/4018,622389439,MDEyOklzc3VlQ29tbWVudDYyMjM4OTQzOQ==,1700203,2020-05-01T13:32:02Z,2020-05-01T13:32:02Z,CONTRIBUTOR,@dcherian I think this would be ready for review now. I'd appreciate some guidance on the implementation of the tests; see above.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,610687463
https://github.com/pydata/xarray/pull/4018#issuecomment-622342323,https://api.github.com/repos/pydata/xarray/issues/4018,622342323,MDEyOklzc3VlQ29tbWVudDYyMjM0MjMyMw==,1700203,2020-05-01T10:51:20Z,2020-05-01T10:51:20Z,CONTRIBUTOR,"Currently, the error that is raised by `coerce_nc3_dtype` is not covered by tests.

A test could look something like this:

```python
    def test_dtype_coercion_error(self):
        for dtype in _nc3_dtype_coercions:
            if dtype == ""bool"":
                continue

            # Create some data that cannot be coerced (cause it's a downcast)
            dtype = np.dtype(dtype)
            maxval = np.iinfo(dtype).max
            x = np.array([0, 1, 2, maxval], dtype=dtype)
            test_data = Dataset({""x"": (""t"", x, {})})

            # Make sure a roundtrip fails
            with pytest.raises(ValueError, match=""could not safely cast""):
                self.roundtrip(test_data)
```

... but I'm not sure ...
* whether this would be desirable to test
* whether this PR should take care of this or not
* where in `test_backend.py` I would have to put the test case such that it's invoked only for netcdf3. 
  * I already found the `NetCDF3Only` class and `requires_scipy` decorator, but don't know which test class is responsible here ...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,610687463