html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3926#issuecomment-607600197,https://api.github.com/repos/pydata/xarray/issues/3926,607600197,MDEyOklzc3VlQ29tbWVudDYwNzYwMDE5Nw==,24736507,2020-04-02T03:26:04Z,2020-06-24T14:38:55Z,NONE,"Hello @TomNicholas! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:











There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-06-24 14:38:55 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,592331420
https://github.com/pydata/xarray/pull/3926#issuecomment-611372701,https://api.github.com/repos/pydata/xarray/issues/3926,611372701,MDEyOklzc3VlQ29tbWVudDYxMTM3MjcwMQ==,35968931,2020-04-09T07:19:34Z,2020-04-09T07:19:34Z,MEMBER,"Just noticed there's a [section](http://xarray.pydata.org/en/stable/api.html#deprecated-pending-deprecation) of the API reference for `Deprecated/Pending Deprecation`, but `auto_combine` was never added to it...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,592331420
https://github.com/pydata/xarray/pull/3926#issuecomment-608015240,https://api.github.com/repos/pydata/xarray/issues/3926,608015240,MDEyOklzc3VlQ29tbWVudDYwODAxNTI0MA==,14808389,2020-04-02T18:02:12Z,2020-04-02T18:02:12Z,MEMBER,"thanks, @TomNicholas, looks good to me.

I opened #3928 for the `upstream-dev` failures.","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 1, ""rocket"": 0, ""eyes"": 0}",,592331420
https://github.com/pydata/xarray/pull/3926#issuecomment-607979472,https://api.github.com/repos/pydata/xarray/issues/3926,607979472,MDEyOklzc3VlQ29tbWVudDYwNzk3OTQ3Mg==,5635139,2020-04-02T17:18:04Z,2020-04-02T17:57:56Z,MEMBER,"I think `FutureWarning` and `DeprecationWarning` are pretty similar — mostly focused on whether the behavior will change or the API is going away. 
~`FutureDeprecationWarning`~ `PendingDeprecationWarning` is generally lower visibility IIRC.

So maybe this should have been `DeprecationWarning` but no need to go through another cycle imo.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,592331420
https://github.com/pydata/xarray/pull/3926#issuecomment-608010931,https://api.github.com/repos/pydata/xarray/issues/3926,608010931,MDEyOklzc3VlQ29tbWVudDYwODAxMDkzMQ==,14808389,2020-04-02T17:54:09Z,2020-04-02T17:57:28Z,MEMBER,"> The warning messages said ""will no longer accept"" and ""will require"" in ""version 0.15"" - that's probably authoritative enough isn't it?

I'd think so, yes. Rereading what the warnings are intended for, [`FutureWarning`](https://docs.python.org/3/library/exceptions.html#FutureWarning) is indeed the same as [`DeprecationWarning`](https://docs.python.org/3/library/exceptions.html#DeprecationWarning), the only difference is the intended target audience. I seem to have confused `FutureWarning` with `PendingDeprecationWarning`.

Then my only issue is with the `whats-new.rst` entry. I'd explicitly state that `auto_combine` was removed.

Edit: sorry, you also mentioned that. The way I understood ""deprecating"" was what you meant with ""starting the deprecation cycle"", so that's where the confusion came from.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,592331420
https://github.com/pydata/xarray/pull/3926#issuecomment-607989892,https://api.github.com/repos/pydata/xarray/issues/3926,607989892,MDEyOklzc3VlQ29tbWVudDYwNzk4OTg5Mg==,35968931,2020-04-02T17:36:19Z,2020-04-02T17:36:39Z,MEMBER,"> To make the docs CI pass

Thanks @keewis .

> Shouldn't we change the FutureWarning to a DeprecationWarning before removing auto_combine? 

I wasn't even aware that there were two types of warnings I could have used for this. I was taking ""deprecating"" to mean ""removed"" and ""starting the deprecation cycle"" to mean ""start warning people it will soon be removed"". The warning messages said ""will no longer accept"" and ""will require"" in ""version 0.15"" - that's probably authoritative enough isn't it?

> There was a case I ran in to where the old auto_combine was needed and none of the newer options worked.

I think that was always a possible edge case - I would very much like to see it though @dcherian , if only so that we can put a ""what to do if"" section in the docs.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,592331420
https://github.com/pydata/xarray/pull/3926#issuecomment-607980436,https://api.github.com/repos/pydata/xarray/issues/3926,607980436,MDEyOklzc3VlQ29tbWVudDYwNzk4MDQzNg==,2448579,2020-04-02T17:19:53Z,2020-04-02T17:19:53Z,MEMBER,"There was a case I ran in to where the old `auto_combine` was needed and none of the newer options worked.

Let me see if I can dig it up.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,592331420
https://github.com/pydata/xarray/pull/3926#issuecomment-607807193,https://api.github.com/repos/pydata/xarray/issues/3926,607807193,MDEyOklzc3VlQ29tbWVudDYwNzgwNzE5Mw==,35968931,2020-04-02T12:10:33Z,2020-04-02T12:10:33Z,MEMBER,It would also be good to include any improvement to the relevant docs (e.g. #3830) in the same release.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,592331420