html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/3894#issuecomment-676669386,https://api.github.com/repos/pydata/xarray/issues/3894,676669386,MDEyOklzc3VlQ29tbWVudDY3NjY2OTM4Ng==,1217238,2020-08-19T20:32:24Z,2020-08-19T20:32:24Z,MEMBER,"At most, I would require using the new method if you want your code to type-check properly.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,588112617
https://github.com/pydata/xarray/issues/3894#issuecomment-675058654,https://api.github.com/repos/pydata/xarray/issues/3894,675058654,MDEyOklzc3VlQ29tbWVudDY3NTA1ODY1NA==,1217238,2020-08-17T19:05:47Z,2020-08-17T19:05:47Z,MEMBER,"> > It would be better to have an explicit method for subsetting Dataset variables.
>
> I agree. `sel_vars` is more clear IMO since `subset` could apply to the coordinates too e.g. a spatial subset.
We did a similar splitting of functionality recently with `drop`, into `drop_vars` and `drop_sel`.
So this would leave us with:
- `sel`/`drop_sel` for indices
- `sel_vars`/`drop_vars` for variables
The naming doesn't have an obvious pattern here, which seems non-ideal. I can't think of anything much better at the moment, but perhaps it would help to avoid reusing `sel`. Maybe `get_vars` or `subset_vars`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,588112617
https://github.com/pydata/xarray/issues/3894#issuecomment-674440470,https://api.github.com/repos/pydata/xarray/issues/3894,674440470,MDEyOklzc3VlQ29tbWVudDY3NDQ0MDQ3MA==,1217238,2020-08-15T19:48:55Z,2020-08-15T19:48:55Z,MEMBER,"I agree, this API is too overloaded. It would be better to have an explicit method for subsetting `Dataset` variables. Maybe `subset` or `sel_vars`?
In early versions of xarray (back when it was called xray), we actually had a `select` method but I was concerned it was too confusing with indexing: http://xarray.pydata.org/en/v0.1.1/generated/xray.Dataset.select.html#xray.Dataset.select
> What's the reasoning for not returning a Dataset when `__getitem__` is passed an Iterable like `_copy_listed`?
The current check uses hashability to determine whether to try to make a DataArray. In theory, you could put a variable with the name `('a', 'b', 'c')` into a Dataset.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,588112617