html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/3891#issuecomment-612501095,https://api.github.com/repos/pydata/xarray/issues/3891,612501095,MDEyOklzc3VlQ29tbWVudDYxMjUwMTA5NQ==,5635139,2020-04-11T19:52:37Z,2020-04-11T19:52:37Z,MEMBER,"> > Would we want a deprecation warning on any operation with an attr? > > That would be almost every operation wouldn't it? Right, anything involving an object with `attrs`... hence my reluctance. Do we think it's OK to do this on a major version without a warning? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,587895591 https://github.com/pydata/xarray/issues/3891#issuecomment-609830530,https://api.github.com/repos/pydata/xarray/issues/3891,609830530,MDEyOklzc3VlQ29tbWVudDYwOTgzMDUzMA==,5635139,2020-04-06T14:30:26Z,2020-04-06T14:30:26Z,MEMBER,"Great, thanks @TomNicholas , appreciate the thoughtful reply. One thing we could do (NB: I don't think we should do this right now, but building on the points above as ideation) is to defer to the `attrs` themselves. For example, in an operation dividing one dataarray by another, if they both share an attr which has a `__div__` method, we call that and put the returned value on the resulting dataarray. That way, even ex-pint integration, `Unit('m')` / `Unit('s')` could evaluate to `Unit('m/s')`. And where units want to be dropped, they could use those methods to return `None`. Re next steps on setting the default to be `True`, what are people's thoughts? Would we take a PR for 0.16? Would we want a deprecation warning on any operation with an attr?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,587895591 https://github.com/pydata/xarray/issues/3891#issuecomment-604445960,https://api.github.com/repos/pydata/xarray/issues/3891,604445960,MDEyOklzc3VlQ29tbWVudDYwNDQ0NTk2MA==,5635139,2020-03-26T13:57:47Z,2020-03-26T13:57:47Z,MEMBER,"> Why would you want a `.drop_attrs()` method? `.attrs.clear()` will do just fine. Yes that's fine if people are happy with `.attrs.clear()`. A method that returns the dataset object is useful for ""fluent"" method chaining. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,587895591