html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3816#issuecomment-624759540,https://api.github.com/repos/pydata/xarray/issues/3816,624759540,MDEyOklzc3VlQ29tbWVudDYyNDc1OTU0MA==,2448579,2020-05-06T16:41:48Z,2020-05-06T16:41:48Z,MEMBER,Thanks for the reviews everyone.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,573768194
https://github.com/pydata/xarray/pull/3816#issuecomment-624221236,https://api.github.com/repos/pydata/xarray/issues/3816,624221236,MDEyOklzc3VlQ29tbWVudDYyNDIyMTIzNg==,2448579,2020-05-05T18:14:06Z,2020-05-05T18:14:06Z,MEMBER,"Added docs on attrs issue. This should be good to go.

Thanks for the kind words, @bradyrx ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,573768194
https://github.com/pydata/xarray/pull/3816#issuecomment-595737538,https://api.github.com/repos/pydata/xarray/issues/3816,595737538,MDEyOklzc3VlQ29tbWVudDU5NTczNzUzOA==,24736507,2020-03-06T11:59:59Z,2020-05-05T18:13:17Z,NONE,"Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:









There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-05-05 18:13:17 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,573768194
https://github.com/pydata/xarray/pull/3816#issuecomment-624158963,https://api.github.com/repos/pydata/xarray/issues/3816,624158963,MDEyOklzc3VlQ29tbWVudDYyNDE1ODk2Mw==,8881170,2020-05-05T16:28:26Z,2020-05-05T16:28:26Z,CONTRIBUTOR,"I missed this originally @dcherian, but thanks for the great work here. The docs changes are a great help.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,573768194
https://github.com/pydata/xarray/pull/3816#issuecomment-622140922,https://api.github.com/repos/pydata/xarray/issues/3816,622140922,MDEyOklzc3VlQ29tbWVudDYyMjE0MDkyMg==,1217238,2020-04-30T22:05:50Z,2020-04-30T22:05:50Z,MEMBER,"I think it's also a good idea to use a different name from dask's `meta` because `template` is used differently. It's an object with the full shape of the desired output, not size 0 dimensions.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,573768194
https://github.com/pydata/xarray/pull/3816#issuecomment-622128514,https://api.github.com/repos/pydata/xarray/issues/3816,622128514,MDEyOklzc3VlQ29tbWVudDYyMjEyODUxNA==,1312546,2020-04-30T21:38:21Z,2020-04-30T21:38:21Z,MEMBER,"Makes sense. template seems fine.

On Thu, Apr 30, 2020 at 3:35 PM Deepak Cherian <notifications@github.com>
wrote:

> Thanks for the review @TomAugspurger <https://github.com/TomAugspurger>
>
> Question on the name template. I think in dask.dataframe and dask.array
> we might call this meta. Is that keyword already used elsewhere in
> xarray? template is also a fine name though.
>
> I added the meta kwarg to apply_ufunc so that users could pass that down
> to dask i.e. that meta = dask's meta = np.ndarray or something like that.
> So I'd like to avoid reusing meta here where it would exclusively be an
> xarray object ≠ dask's meta
>
> BUT it seems to me like there's a better name than template. Any ideas?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pydata/xarray/pull/3816#issuecomment-622095710>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAKAOIQWE7DGYAOSJWLG5F3RPHOI7ANCNFSM4K7ODDRA>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,573768194
https://github.com/pydata/xarray/pull/3816#issuecomment-622095710,https://api.github.com/repos/pydata/xarray/issues/3816,622095710,MDEyOklzc3VlQ29tbWVudDYyMjA5NTcxMA==,2448579,2020-04-30T20:35:13Z,2020-04-30T20:35:13Z,MEMBER,"Thanks for the review @TomAugspurger 


> Question on the name `template`. I think in dask.dataframe and dask.array we might call this `meta`. Is that keyword already used elsewhere in xarray? `template` is also a fine name though.

I added the `meta` kwarg to `apply_ufunc` so that users could pass that down to dask i.e. that meta = dask's meta = np.ndarray or something like that. So I'd like to avoid reusing `meta` here where it would exclusively be an xarray object ≠ dask's meta

 BUT it seems to me like there's a better name than `template`. Any ideas?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,573768194
https://github.com/pydata/xarray/pull/3816#issuecomment-621601134,https://api.github.com/repos/pydata/xarray/issues/3816,621601134,MDEyOklzc3VlQ29tbWVudDYyMTYwMTEzNA==,1217238,2020-04-30T04:11:22Z,2020-04-30T04:11:22Z,MEMBER,"Looks really nice! I like this design, just a few minor concerns.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,573768194
https://github.com/pydata/xarray/pull/3816#issuecomment-601887703,https://api.github.com/repos/pydata/xarray/issues/3816,601887703,MDEyOklzc3VlQ29tbWVudDYwMTg4NzcwMw==,2448579,2020-03-20T20:04:06Z,2020-03-20T20:04:06Z,MEMBER,Thanks for the review @aaronspring ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,573768194