html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/3750#issuecomment-624402070,https://api.github.com/repos/pydata/xarray/issues/3750,624402070,MDEyOklzc3VlQ29tbWVudDYyNDQwMjA3MA==,1810591,2020-05-06T01:50:29Z,2020-05-06T01:50:29Z,NONE,"fwiw, the problem here is the `-2` tag of isort is broken -- you want 4.3.21 which [properly specifies `types: [python]`](https://github.com/timothycrosley/isort/commit/30e15ab8251b682e48a1afe76dd65f7bdf39257b)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,559864146
https://github.com/pydata/xarray/issues/3750#issuecomment-582654456,https://api.github.com/repos/pydata/xarray/issues/3750,582654456,MDEyOklzc3VlQ29tbWVudDU4MjY1NDQ1Ng==,14808389,2020-02-05T23:01:09Z,2020-02-05T23:01:09Z,MEMBER,"actually, `isort` does support filtering using `--filter-files -sg '*.rst'` which would blacklist `rst` files. Since we don't have just `rst` files, I think that whitelisting is a better approach. Maybe we should use `files: .\.py$`?","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,559864146
https://github.com/pydata/xarray/issues/3750#issuecomment-582651268,https://api.github.com/repos/pydata/xarray/issues/3750,582651268,MDEyOklzc3VlQ29tbWVudDU4MjY1MTI2OA==,10194086,2020-02-05T22:50:54Z,2020-02-05T22:50:54Z,MEMBER,"You can tell isort to skip files in the `setup.cfg` but this seems to be ignored when doing `isort file` (which is what happens in the pre-commit hook) - see https://github.com/pre-commit/mirrors-isort/issues/9#issuecomment-511434587

So I think adapting `.pre-commit-config.yaml` is the way to go at the moment. (Maybe adapt `setup.cfg` anyway to ensure it does not happen when isort is called with `isort -rc .`).","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,559864146
https://github.com/pydata/xarray/issues/3750#issuecomment-582127727,https://api.github.com/repos/pydata/xarray/issues/3750,582127727,MDEyOklzc3VlQ29tbWVudDU4MjEyNzcyNw==,14808389,2020-02-04T21:38:41Z,2020-02-04T21:38:41Z,MEMBER,"`pre-commit` allows filtering the files passed to a hook using regular expressions:
```diff
   - repo: https://github.com/timothycrosley/isort
     rev: 4.3.21-2
     hooks:
       - id: isort
+        files: "".+[.]py""
   # https://github.com/python/black#version-control-integration
   - repo: https://github.com/python/black
```
Not sure if this regex is the one we should use, but it does seem to work.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,559864146