html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/3714#issuecomment-578626605,https://api.github.com/repos/pydata/xarray/issues/3714,578626605,MDEyOklzc3VlQ29tbWVudDU3ODYyNjYwNQ==,1217238,2020-01-27T07:42:36Z,2020-01-27T07:42:36Z,MEMBER,"This is a lovely clean-up, but unfortunately I think it broke GitHub's ""Used by"" feature, which no longer appears at the top of this repository: https://twitter.com/shoyer/status/1221676802793295872 It's kind of awkward, but maybe we should add a minimal `requirements.txt` file for the benefit of GitHub?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,553518018 https://github.com/pydata/xarray/pull/3714#issuecomment-578060759,https://api.github.com/repos/pydata/xarray/issues/3714,578060759,MDEyOklzc3VlQ29tbWVudDU3ODA2MDc1OQ==,6213168,2020-01-24T09:46:20Z,2020-01-24T09:46:20Z,MEMBER,"@keewis interesting question. setuptools is technically not part of the Python standard library, but it is part of pip and is always included with the cpython binaries, `conda create python=3.6`, and pypy. So... I'm not sure?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,553518018 https://github.com/pydata/xarray/pull/3714#issuecomment-577306958,https://api.github.com/repos/pydata/xarray/issues/3714,577306958,MDEyOklzc3VlQ29tbWVudDU3NzMwNjk1OA==,5635139,2020-01-22T17:53:14Z,2020-01-22T17:53:14Z,MEMBER,"Awesome! Thanks @crusaderky & @keewis . FWIW I don't think we need a `MANIFEST.in` now; setuptools_scm uses whatever is tracked by source control. But no harm either","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,553518018 https://github.com/pydata/xarray/pull/3714#issuecomment-577290866,https://api.github.com/repos/pydata/xarray/issues/3714,577290866,MDEyOklzc3VlQ29tbWVudDU3NzI5MDg2Ng==,14808389,2020-01-22T17:15:17Z,2020-01-22T17:15:17Z,MEMBER,don't we need to put `setuptools` (of which `pkg_resources` is a part of) into `install_requires`?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,553518018 https://github.com/pydata/xarray/pull/3714#issuecomment-577246366,https://api.github.com/repos/pydata/xarray/issues/3714,577246366,MDEyOklzc3VlQ29tbWVudDU3NzI0NjM2Ng==,2448579,2020-01-22T15:40:37Z,2020-01-22T15:40:37Z,MEMBER,Thanks @crusaderky & @keewis ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,553518018 https://github.com/pydata/xarray/pull/3714#issuecomment-577205054,https://api.github.com/repos/pydata/xarray/issues/3714,577205054,MDEyOklzc3VlQ29tbWVudDU3NzIwNTA1NA==,6213168,2020-01-22T14:24:52Z,2020-01-22T14:24:52Z,MEMBER,"Awesome, everything looks in order. This is now ready for review and merge.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,553518018 https://github.com/pydata/xarray/pull/3714#issuecomment-577204651,https://api.github.com/repos/pydata/xarray/issues/3714,577204651,MDEyOklzc3VlQ29tbWVudDU3NzIwNDY1MQ==,14808389,2020-01-22T14:24:00Z,2020-01-22T14:24:00Z,MEMBER,"and now it passed, see https://readthedocs.org/projects/xray/builds/10306203/","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,553518018 https://github.com/pydata/xarray/pull/3714#issuecomment-577195282,https://api.github.com/repos/pydata/xarray/issues/3714,577195282,MDEyOklzc3VlQ29tbWVudDU3NzE5NTI4Mg==,14808389,2020-01-22T14:02:40Z,2020-01-22T14:02:40Z,MEMBER,"hmm... that timed out (see the link above), which also happened before this PR (see #3697). I'll try rebuilding.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,553518018 https://github.com/pydata/xarray/pull/3714#issuecomment-577178942,https://api.github.com/repos/pydata/xarray/issues/3714,577178942,MDEyOklzc3VlQ29tbWVudDU3NzE3ODk0Mg==,6213168,2020-01-22T13:22:29Z,2020-01-22T13:22:29Z,MEMBER,@keewis done,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,553518018 https://github.com/pydata/xarray/pull/3714#issuecomment-577175213,https://api.github.com/repos/pydata/xarray/issues/3714,577175213,MDEyOklzc3VlQ29tbWVudDU3NzE3NTIxMw==,14808389,2020-01-22T13:12:25Z,2020-01-22T13:18:38Z,MEMBER,"push your branch to the main repository, I'll activate it Edit: I did it for you: https://readthedocs.org/projects/xray/builds/10305931/","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,553518018 https://github.com/pydata/xarray/pull/3714#issuecomment-577174666,https://api.github.com/repos/pydata/xarray/issues/3714,577174666,MDEyOklzc3VlQ29tbWVudDU3NzE3NDY2Ng==,6213168,2020-01-22T13:10:57Z,2020-01-22T13:10:57Z,MEMBER,"I seem to have no way to test RTD >_< https://readthedocs.org/projects/crusaderky-xarray/builds/10305870/ ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,553518018 https://github.com/pydata/xarray/pull/3714#issuecomment-577168867,https://api.github.com/repos/pydata/xarray/issues/3714,577168867,MDEyOklzc3VlQ29tbWVudDU3NzE2ODg2Nw==,6213168,2020-01-22T12:54:38Z,2020-01-22T12:54:38Z,MEMBER,I need to retest the RTD CI before merging,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,553518018