html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3713#issuecomment-578314288,https://api.github.com/repos/pydata/xarray/issues/3713,578314288,MDEyOklzc3VlQ29tbWVudDU3ODMxNDI4OA==,2448579,2020-01-24T21:45:43Z,2020-01-24T21:46:46Z,MEMBER,"> the most recent version released more than X months ago.
To me, this seems most sensible.
EDIT: crusaderky's 1 year proposal sounds good too","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-578312410,https://api.github.com/repos/pydata/xarray/issues/3713,578312410,MDEyOklzc3VlQ29tbWVudDU3ODMxMjQxMA==,6213168,2020-01-24T21:39:46Z,2020-01-24T21:39:46Z,MEMBER,We could increase the support window for seldom-updated packages (read: not dask) to 1 year. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-578295750,https://api.github.com/repos/pydata/xarray/issues/3713,578295750,MDEyOklzc3VlQ29tbWVudDU3ODI5NTc1MA==,5635139,2020-01-24T20:48:46Z,2020-01-24T20:48:46Z,MEMBER,"For sure no harm in keeping older ones for this release. But to the extent we can have a policy we agree on, then it's not a judgement call each release. Should we change the policy?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-578288717,https://api.github.com/repos/pydata/xarray/issues/3713,578288717,MDEyOklzc3VlQ29tbWVudDU3ODI4ODcxNw==,6213168,2020-01-24T20:28:25Z,2020-01-24T20:28:25Z,MEMBER,I have no problems with supporting versions older than those mandated by the policy as long as there isn't any major benefit in dropping them... ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-576784205,https://api.github.com/repos/pydata/xarray/issues/3713,576784205,MDEyOklzc3VlQ29tbWVudDU3Njc4NDIwNQ==,24736507,2020-01-21T17:13:35Z,2020-01-24T17:47:42Z,NONE,"Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
##### Comment last updated at 2020-01-24 17:47:42 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-578231137,https://api.github.com/repos/pydata/xarray/issues/3713,578231137,MDEyOklzc3VlQ29tbWVudDU3ODIzMTEzNw==,2448579,2020-01-24T17:47:10Z,2020-01-24T17:47:10Z,MEMBER,"bumping the following seems a little excessive to me.
```
bottleneck 1.2 (2017-09-18) 1.3 (2019-11-13) <
iris 2.2 (2018-10-12) 2.3 (2019-12-21) <
numba 0.44 (2019-06-18) 0.46 (2019-10-25) <
pseudonetcdf 3.0 (2019-07-18) 3.1 (2019-10-18) <
rasterio 1.0 (2018-12-21) 1.1 (2019-10-15) <
zarr 2.3 (2019-03-25) 2.4 (2020-01-11) <
```
Is anyone opposed to merging this PR in its current form and bumping up minimum versions at the next major release?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-577816539,https://api.github.com/repos/pydata/xarray/issues/3713,577816539,MDEyOklzc3VlQ29tbWVudDU3NzgxNjUzOQ==,6213168,2020-01-23T18:40:29Z,2020-01-23T18:40:29Z,MEMBER,"Because NEP29 states support for all versions in the latest X months, not the most recent version released more than X months ago. ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-577253423,https://api.github.com/repos/pydata/xarray/issues/3713,577253423,MDEyOklzc3VlQ29tbWVudDU3NzI1MzQyMw==,2448579,2020-01-22T15:55:19Z,2020-01-22T15:55:19Z,MEMBER,"This output is confusing to me. It hasn't been 6 months since bottleneck 1.3 was released. Why is that the ""policy version"". Similarly for zarr 2.4
```
Package Required Policy Status
------------- -------------------- -------------------- ------
python 3.6 (2016-12-23) 3.6 (2016-12-23) =
boto3 1.9 (2018-09-10) 1.10 (2019-10-22) <
bottleneck 1.2 (2017-09-18) 1.3 (2019-11-13) <
cartopy 0.17 (2018-11-17) 0.17 (2018-11-17) =
cdms2 3.1 (2018-11-02) 3.1 (2018-11-02) =
cfgrib 0.9 (2019-02-25) 0.9 (2019-02-25) =
cftime 1.0 (2018-04-27) 1.0 (2018-04-27) =
dask 1.2 (2019-04-13) 2.2 (2019-08-01) <
distributed 1.27 (2019-04-12) 2.2 (2019-08-01) <
h5netcdf 0.7 (2019-02-27) 0.7 (2019-02-27) =
h5py 2.9 (2018-12-20) 2.10 (2019-09-10) <
hdf5 1.10 (2017-09-18) 1.10 (2017-09-18) =
iris 2.2 (2018-10-12) 2.3 (2019-12-21) <
lxml 4.4 (2019-07-27) 4.4 (2019-07-27) =
matplotlib 3.1 (2019-05-18) 3.1 (2019-05-18) =
nc-time-axis 1.2 (2019-01-25) 1.2 (2019-01-25) =
netcdf4 1.4 (2018-05-08) 1.4 (2018-05-08) =
numba 0.44 (2019-06-18) 0.46 (2019-10-25) <
numpy 1.15 (2018-07-27) 1.15 (2018-07-27) =
pandas 0.25 (2019-07-18) 0.25 (2019-07-18) =
pseudonetcdf 3.0 (2019-07-18) 3.1 (2019-10-18) <
pydap 3.2 (2018-10-16) 3.2 (2018-10-16) =
pynio 1.5 (2017-12-01) 1.5 (2017-12-01) =
rasterio 1.0 (2018-12-21) 1.1 (2019-10-15) <
scipy 1.3 (2019-05-28) 1.3 (2019-05-28) =
seaborn 0.9 (2018-07-17) 0.9 (2018-07-17) =
toolz 0.10 (2019-07-12) 0.10 (2019-07-12) =
zarr 2.3 (2019-03-25) 2.4 (2020-01-11) <
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-577166188,https://api.github.com/repos/pydata/xarray/issues/3713,577166188,MDEyOklzc3VlQ29tbWVudDU3NzE2NjE4OA==,6213168,2020-01-22T12:51:48Z,2020-01-22T12:51:48Z,MEMBER,Related: #3714 ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-576785872,https://api.github.com/repos/pydata/xarray/issues/3713,576785872,MDEyOklzc3VlQ29tbWVudDU3Njc4NTg3Mg==,14808389,2020-01-21T17:17:22Z,2020-01-21T17:17:22Z,MEMBER,I think it's fine if you mark the failing tests as `xfail`,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-576784963,https://api.github.com/repos/pydata/xarray/issues/3713,576784963,MDEyOklzc3VlQ29tbWVudDU3Njc4NDk2Mw==,2448579,2020-01-21T17:15:22Z,2020-01-21T17:15:22Z,MEMBER,"> as @jthielen said, it does not since I never realized we used nanquantile (did we change that recently?).
I changed it in this PR. But I guess I could just revert that bit","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-576783960,https://api.github.com/repos/pydata/xarray/issues/3713,576783960,MDEyOklzc3VlQ29tbWVudDU3Njc4Mzk2MA==,14808389,2020-01-21T17:13:05Z,2020-01-21T17:13:05Z,MEMBER,"as @jthielen said, it does not since I never realized we used `nanquantile` (did we change that recently?). For now, I'd mark these tests as `xfail(reason=""not implemented by pint"")` since none of the pint-support PRs are merged yet. Can be a new PR, though.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-576782065,https://api.github.com/repos/pydata/xarray/issues/3713,576782065,MDEyOklzc3VlQ29tbWVudDU3Njc4MjA2NQ==,3460034,2020-01-21T17:08:39Z,2020-01-21T17:08:39Z,CONTRIBUTOR,"> looks like pint doesn't have `nanquantile`?
@dcherian Hope you don't mind me jumping in, but that is correct at the moment (see https://github.com/hgrecco/pint/issues/981). It would be easy to add to Pint, though.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673
https://github.com/pydata/xarray/pull/3713#issuecomment-576779512,https://api.github.com/repos/pydata/xarray/issues/3713,576779512,MDEyOklzc3VlQ29tbWVudDU3Njc3OTUxMg==,2448579,2020-01-21T17:03:15Z,2020-01-21T17:03:15Z,MEMBER,"@keewis: looks like pint doesn't have `nanquantile`? https://dev.azure.com/xarray/xarray/_build/results?buildId=1989&view=logs&jobId=78b48a04-306f-5a15-9ac3-dd2fdb28db5e&j=acc1347f-8235-55b0-95c7-0e2189e61659&t=7284452c-b1fa-561e-b473-09e477cf0d79
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,552994673