html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3706#issuecomment-590105084,https://api.github.com/repos/pydata/xarray/issues/3706,590105084,MDEyOklzc3VlQ29tbWVudDU5MDEwNTA4NA==,2448579,2020-02-23T19:13:03Z,2020-02-23T19:13:03Z,MEMBER,Test failures look unrelated. Thanks @keewis ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,551680561
https://github.com/pydata/xarray/pull/3706#issuecomment-582476396,https://api.github.com/repos/pydata/xarray/issues/3706,582476396,MDEyOklzc3VlQ29tbWVudDU4MjQ3NjM5Ng==,2448579,2020-02-05T15:57:10Z,2020-02-05T15:57:10Z,MEMBER,"> let's mark these tests as xfail and discuss this in their own issues / PRs.

:+1: to smaller PRs!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,551680561
https://github.com/pydata/xarray/pull/3706#issuecomment-578178685,https://api.github.com/repos/pydata/xarray/issues/3706,578178685,MDEyOklzc3VlQ29tbWVudDU3ODE3ODY4NQ==,2448579,2020-01-24T15:31:32Z,2020-01-24T15:31:32Z,MEMBER,OK let's see what @shoyer thinks,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,551680561
https://github.com/pydata/xarray/pull/3706#issuecomment-577977929,https://api.github.com/repos/pydata/xarray/issues/3706,577977929,MDEyOklzc3VlQ29tbWVudDU3Nzk3NzkyOQ==,2448579,2020-01-24T03:34:04Z,2020-01-24T03:34:04Z,MEMBER,"I guess we need to either pass a kwarg regarding checking units/dimensionality down to `lazy_array_equiv` or add a `units_equiv(only_dimensionality=True/False)` check to https://github.com/pydata/xarray/blob/6d1434e9b9e9766d6fcafceb05e81734b29994ea/xarray/core/variable.py#L1645-L1648

I think a separate `units_equiv` function may be cleaner?

Note that we explicitly use `lazy_array_equiv` in `concat` so it'd be nice to have something that could be easily used there too:
https://github.com/pydata/xarray/blob/6d1434e9b9e9766d6fcafceb05e81734b29994ea/xarray/core/concat.py#L194-L208","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,551680561
https://github.com/pydata/xarray/pull/3706#issuecomment-577894139,https://api.github.com/repos/pydata/xarray/issues/3706,577894139,MDEyOklzc3VlQ29tbWVudDU3Nzg5NDEzOQ==,2448579,2020-01-23T21:51:52Z,2020-01-23T21:51:52Z,MEMBER,"> re rolling_window: should I leave it as xfail for now?

Fine by me. :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,551680561
https://github.com/pydata/xarray/pull/3706#issuecomment-577894064,https://api.github.com/repos/pydata/xarray/issues/3706,577894064,MDEyOklzc3VlQ29tbWVudDU3Nzg5NDA2NA==,2448579,2020-01-23T21:51:39Z,2020-01-23T21:51:39Z,MEMBER,"`array_equiv` calls `lazy_array_equiv` before doing much else:

https://github.com/pydata/xarray/blob/6d1434e9b9e9766d6fcafceb05e81734b29994ea/xarray/core/duck_array_ops.py#L215-L227","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,551680561
https://github.com/pydata/xarray/pull/3706#issuecomment-577885631,https://api.github.com/repos/pydata/xarray/issues/3706,577885631,MDEyOklzc3VlQ29tbWVudDU3Nzg4NTYzMQ==,2448579,2020-01-23T21:29:14Z,2020-01-23T21:29:14Z,MEMBER,"I think your `units_equiv` thing could go in `duck_array_ops.lazy_array_equiv` which tries to check everything but the actual values themselves.

>  but I don't know how to fix that unless we rewrite _rolling_window or dispatch differently in rolling_window.

This may be necessary but perhaps not the most important thing right now?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,551680561