html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3706#issuecomment-589862431,https://api.github.com/repos/pydata/xarray/issues/3706,589862431,MDEyOklzc3VlQ29tbWVudDU4OTg2MjQzMQ==,1217238,2020-02-21T22:23:31Z,2020-02-21T22:23:31Z,MEMBER,"> Also, concerning the commutative operations: should we wait for [hgrecco/pint#1019](https://github.com/hgrecco/pint/issues/1019) and remove the flipped parameters or should we merge as is and possibly revert once `pint` implements a type casting hierarchy?

I don't anticipate any performance cost to this, just a small decrease in readability. So I think this is fine to merge for now with comments in the relevant sections and we can revert it later. My only suggestion is to add a note like `TODO: revert after https://github.com/hgrecco/pint/issues/1019 is fixed` to each comment.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,551680561
https://github.com/pydata/xarray/pull/3706#issuecomment-583259053,https://api.github.com/repos/pydata/xarray/issues/3706,583259053,MDEyOklzc3VlQ29tbWVudDU4MzI1OTA1Mw==,1217238,2020-02-07T06:52:26Z,2020-02-07T06:52:26Z,MEMBER,"Thanks for pinging me again here (I get a lot of GitHub notifications). `identical` is an interesting case!

I think the current behavior (1 meter is identical to 100 centimeters) is arguably consistent with how `identical` currently works, which only check equality between array elements.

Right now, `identical` considers numbers of different data types equal, e.g., int `1` is identical to float 1.0``. I think units arguably have a similar to role to data types -- hopefully eventually libraries like `pint` could be implemented via custom NumPy dtypes, rather than needing to reimplement all of NumPy.

Did this come up in the context of some other downstream use-case, or is this just something that occurred to you for the sake of consistency?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,551680561