html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/3646#issuecomment-898702359,https://api.github.com/repos/pydata/xarray/issues/3646,898702359,IC_kwDOAMm_X841kRwX,41898282,2021-08-13T20:24:18Z,2021-11-01T00:42:50Z,CONTRIBUTOR,"## Unit Test Results          6 files           6 suites   56m 9s [:stopwatch:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""duration of all tests"") 16 295 tests 14 556 [:heavy_check_mark:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""passed tests"") 1 739 [:zzz:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""skipped / disabled tests"") 0 [:x:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""failed tests"") 90 966 runs  82 768 [:heavy_check_mark:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""passed tests"") 8 198 [:zzz:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""skipped / disabled tests"") 0 [:x:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v1.20/README.md#the-symbols ""failed tests"") Results for commit 8f4ea871. :recycle: This comment has been updated with latest results.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,540451721 https://github.com/pydata/xarray/pull/3646#issuecomment-569966964,https://api.github.com/repos/pydata/xarray/issues/3646,569966964,MDEyOklzc3VlQ29tbWVudDU2OTk2Njk2NA==,24736507,2019-12-31T17:59:58Z,2021-11-01T00:19:11Z,NONE,"Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: ##### Comment last updated at 2021-11-01 00:19:11 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,540451721 https://github.com/pydata/xarray/pull/3646#issuecomment-955803547,https://api.github.com/repos/pydata/xarray/issues/3646,955803547,IC_kwDOAMm_X844-Geb,14371165,2021-10-31T22:33:37Z,2021-10-31T22:33:37Z,MEMBER,"A few notes before I forget them: * Docs crashed because UncachedAccessor wasn't used. * _plot2d stuff didn't work because of the missing ndim. * `ds.A.groupby(ds.w).plot.contour(col=""w"", row=""z"")` didn't work even though `ds.A.plot.contour(col=""w"", row=""z"")` did. Made that work. The facegrids aren't an exact copy though, the curves are the same but may be in other subplots, there's some sorting going on somewhere. * I think we should avoid adding DataArrayGroupby to the mix in `plot.py,` I think it'll look cleaner if we always send in pure dataarrays there and do the filtering in DataArrayGroupby.plot instead. Might avoid circular imports then as well.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,540451721 https://github.com/pydata/xarray/pull/3646#issuecomment-898870319,https://api.github.com/repos/pydata/xarray/issues/3646,898870319,IC_kwDOAMm_X841k6wv,14371165,2021-08-14T09:23:34Z,2021-08-14T09:23:34Z,MEMBER,"```python ds = xr.tutorial.scatter_example_dataset() ds.A.groupby(ds.w).plot.contour() ds.A.groupby(ds.w).plot.imshow() ``` These crashes with `AttributeError: 'DataArrayGroupBy' object has no attribute 'ndim'`. Can `NdimSizeLenMixin` be used here?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,540451721 https://github.com/pydata/xarray/pull/3646#issuecomment-898709361,https://api.github.com/repos/pydata/xarray/issues/3646,898709361,IC_kwDOAMm_X841kTdx,2448579,2021-08-13T20:40:33Z,2021-08-13T20:40:33Z,MEMBER,@Illviljan would you mind testing this out and possibly reviewing it?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,540451721 https://github.com/pydata/xarray/pull/3646#issuecomment-715995178,https://api.github.com/repos/pydata/xarray/issues/3646,715995178,MDEyOklzc3VlQ29tbWVudDcxNTk5NTE3OA==,2448579,2020-10-24T16:58:52Z,2020-10-24T16:58:52Z,MEMBER,It should be possible but is not implemented yet.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,540451721 https://github.com/pydata/xarray/pull/3646#issuecomment-715946540,https://api.github.com/repos/pydata/xarray/issues/3646,715946540,MDEyOklzc3VlQ29tbWVudDcxNTk0NjU0MA==,14371165,2020-10-24T15:44:38Z,2020-10-24T15:44:38Z,MEMBER,"This is looking great! Being able to easily plot your groupings like this is so useful. Especially when grouping results isn't trivial and requires a bit of tuning. When I've been doing these kinds of plots I've mostly just changed the colors for each group: ![image](https://user-images.githubusercontent.com/14371165/97085589-abacf180-161e-11eb-9dcd-fa434db865ea.png) Would it be easy to do this with this implementation? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,540451721