html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3600#issuecomment-562905492,https://api.github.com/repos/pydata/xarray/issues/3600,562905492,MDEyOklzc3VlQ29tbWVudDU2MjkwNTQ5Mg==,3460034,2019-12-08T02:15:04Z,2019-12-08T02:15:04Z,CONTRIBUTOR,">  `cumprod` fails using xarray's structures (works fine with `Quantity`), so the xfail is still necessary. I also didn't isolate the dims from any tests other than `align` and I think we still need at least one more iteration to get full isolation (I'd like to leave that to a new PR, though -- maybe when we attempt to silence the `UnitStrippedWarning`s?).

Sounds like a good plan.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,533580931
https://github.com/pydata/xarray/pull/3600#issuecomment-562348563,https://api.github.com/repos/pydata/xarray/issues/3600,562348563,MDEyOklzc3VlQ29tbWVudDU2MjM0ODU2Mw==,3460034,2019-12-05T22:32:44Z,2019-12-05T22:32:44Z,CONTRIBUTOR,"In general, this looks good!

After running through this, a couple thoughts did come to mind:

- Do you have tests of `align`/`combine_*`/`concat` that have Quantity data but no Quantity coordinates? I think these could help isolate the coordinate/indexing issue from the any other operation-related issue.
- Would you be able to alter the `cumprod` tests to test a dimensionless Quantity? `np.cumprod` is only supported (and only really makes sense) for dimensionless Quantities
- Could you change the xfail reason for matrix multiplication to pint not supporting `einsum`? `__matmul__` has been implemented in https://github.com/hgrecco/pint/pull/905, but xarray's `__matmul__` appears to route through `np.einsum`.
- Would it make sense to remove the `np.rank` test as discussed here: https://github.com/hgrecco/pint/pull/905#issuecomment-562109451?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,533580931