html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/3552#issuecomment-563930721,https://api.github.com/repos/pydata/xarray/issues/3552,563930721,MDEyOklzc3VlQ29tbWVudDU2MzkzMDcyMQ==,4160723,2019-12-10T08:50:40Z,2019-12-10T08:50:40Z,MEMBER,"> We should fix set, though for your case it's best to switch to drop_vars

This also happens with other iterables like `dict_keys`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556320664,https://api.github.com/repos/pydata/xarray/issues/3552,556320664,MDEyOklzc3VlQ29tbWVudDU1NjMyMDY2NA==,5635139,2019-11-20T20:00:47Z,2019-11-20T20:00:47Z,MEMBER,"`drop_vars` was just added! Let me know any questions / issues. We should fix `set`, though for your case it's best to switch to `drop_vars`

👍  re @keewis 's point re `ds[variables]`
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556319412,https://api.github.com/repos/pydata/xarray/issues/3552,556319412,MDEyOklzc3VlQ29tbWVudDU1NjMxOTQxMg==,14808389,2019-11-20T19:59:48Z,2019-11-20T19:59:48Z,MEMBER,"the reason for `set` raising an error is that in [`drop`](https://github.com/pydata/xarray/blob/6b70107ab3063187b663290538c0d5a4107dab6e/xarray/core/dataset.py#L3622) `is_list_like(labels) or is_scalar(labels)` is used instead of `isinstance(labels, str) or not isinstance(labels, Iterable)`. Since `is_list_like` explicitly checks for `tuple` and `list`, passing `set` obviously won't call the right method.","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556118230,https://api.github.com/repos/pydata/xarray/issues/3552,556118230,MDEyOklzc3VlQ29tbWVudDU1NjExODIzMA==,1197350,2019-11-20T17:11:24Z,2019-11-20T17:11:24Z,MEMBER,"~`drop_vars` has been deprecated.~  Apparently that is wrong. Sorry for adding to the noise.

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556111055,https://api.github.com/repos/pydata/xarray/issues/3552,556111055,MDEyOklzc3VlQ29tbWVudDU1NjExMTA1NQ==,4179064,2019-11-20T17:05:33Z,2019-11-20T17:05:33Z,NONE,"Ah, thanks very much!  I'll switch to using that syntax instead.","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556105579,https://api.github.com/repos/pydata/xarray/issues/3552,556105579,MDEyOklzc3VlQ29tbWVudDU1NjEwNTU3OQ==,14808389,2019-11-20T17:01:06Z,2019-11-20T17:03:20Z,MEMBER,"explicitly selecting should work like this:
```python
ds = xr.Dataset(
    {""a"": (""b"", [0, 1, 2]), ""c"": (""b"", [-1, 2, 4]), ""d"": (""b"", [5, 1, 3])},
    coords={""b"": list(""abc"")},
)
variables = [""a"", ""d""]
ds[variables]
```
I think `Dataset.__getitem__` allows any kind of sequence here (e.g. sets)","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556096924,https://api.github.com/repos/pydata/xarray/issues/3552,556096924,MDEyOklzc3VlQ29tbWVudDU1NjA5NjkyNA==,4179064,2019-11-20T16:53:40Z,2019-11-20T16:53:40Z,NONE,I apologize for this slight tangent but it's related to why we use sets in `drop()`.  Is there a good way in xarray to only *keep* a list of variables?  Our approach is to create a set of all variable and subtract from it a set of variables we want to keep and to drop the resulting set of variables we *don't* want to keep.  But it's hard for me to imagine others don't also need this functionality.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556095452,https://api.github.com/repos/pydata/xarray/issues/3552,556095452,MDEyOklzc3VlQ29tbWVudDU1NjA5NTQ1Mg==,4179064,2019-11-20T16:50:15Z,2019-11-20T16:50:15Z,NONE,"> Additionally, I think we have a documentation bug: I can't reach the documentation on drop.

Yes, I noticed that, too.  I assumed it wasn't being documented anymore because it was considered deprecated. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556094944,https://api.github.com/repos/pydata/xarray/issues/3552,556094944,MDEyOklzc3VlQ29tbWVudDU1NjA5NDk0NA==,14808389,2019-11-20T16:49:05Z,2019-11-20T16:49:05Z,MEMBER,so I guess we need to figure out why sets don't work anymore?,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556094690,https://api.github.com/repos/pydata/xarray/issues/3552,556094690,MDEyOklzc3VlQ29tbWVudDU1NjA5NDY5MA==,14808389,2019-11-20T16:48:33Z,2019-11-20T16:48:33Z,MEMBER,"I think `drop` was deprecated in favor of `drop_sel` and `drop_vars` (#3475). Using v0.14.1, this works:
```python
ds = xr.Dataset({""a"": (""b"", [0, 1, 2]), ""c"": [-1, 2, 4]}, coords={""b"": list(""abc"")})
ds.drop_vars({""a"", ""b""})
ds.drop_vars([""a"", ""b""])
ds.drop([""a"", ""b""])
```

Additionally, I think we have a documentation bug: I can't reach the documentation on [`drop`](http://xarray.pydata.org/en/stable/generated/xarray.Dataset.drop.html).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556091171,https://api.github.com/repos/pydata/xarray/issues/3552,556091171,MDEyOklzc3VlQ29tbWVudDU1NjA5MTE3MQ==,4179064,2019-11-20T16:41:09Z,2019-11-20T16:43:01Z,NONE,"> @dcherian - are you suggesting that @xylar change his downstream code to use drop_vars instead? drop_vars has been deprecated. I don't think that's the right response here.

I'm confused.  In 0.14.1, `drop_vars` seems to have just been introduced and `drop` seems to have been dropped.

> How about drop_vars instead?

Yes, I switched to `drop_vars` but first I had to make a new build of my conda package that constrains the dependency `xarray <0.14.0` because it's broken with 0.14.1.  So that's why I'm concerned.  I have to do a new release before this fix propagates to my users.

So @rabernat and @dcherian, please clarify if I should be switching to `drop_vars` or if I am going to run into issues yet again if I do so?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556087899,https://api.github.com/repos/pydata/xarray/issues/3552,556087899,MDEyOklzc3VlQ29tbWVudDU1NjA4Nzg5OQ==,2448579,2019-11-20T16:33:49Z,2019-11-20T16:33:49Z,MEMBER,"Yes yes I agree!

`drop_vars` would be a quick unblocking fix...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556084694,https://api.github.com/repos/pydata/xarray/issues/3552,556084694,MDEyOklzc3VlQ29tbWVudDU1NjA4NDY5NA==,1197350,2019-11-20T16:26:43Z,2019-11-20T16:26:43Z,MEMBER,"@dcherian - are you suggesting that @xylar change his downstream code to use `drop_vars` instead? `drop_vars` has been deprecated. I don't think that's the right response here.

Instead we should fix this bug. The docs for drop suggest that you should be able to provide a set as an input. Somehow we made that not work in the latest release.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556079410,https://api.github.com/repos/pydata/xarray/issues/3552,556079410,MDEyOklzc3VlQ29tbWVudDU1NjA3OTQxMA==,2448579,2019-11-20T16:15:19Z,2019-11-20T16:15:19Z,MEMBER,How about `drop_vars` instead?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846
https://github.com/pydata/xarray/issues/3552#issuecomment-556077504,https://api.github.com/repos/pydata/xarray/issues/3552,556077504,MDEyOklzc3VlQ29tbWVudDU1NjA3NzUwNA==,4179064,2019-11-20T16:10:54Z,2019-11-20T16:11:13Z,NONE,"I believe a `set()` object should be a valid `labels` argument according to the documentation of `drop()`:
http://xarray.pydata.org/en/v0.14.0/generated/xarray.Dataset.drop.html#xarray.Dataset.drop","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525903846