html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3475#issuecomment-551311482,https://api.github.com/repos/pydata/xarray/issues/3475,551311482,MDEyOklzc3VlQ29tbWVudDU1MTMxMTQ4Mg==,1217238,2019-11-07T23:20:40Z,2019-11-07T23:20:40Z,MEMBER,"Thank you @max-sixty, and @dcherian for reviewing!","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,515662368
https://github.com/pydata/xarray/pull/3475#issuecomment-551244548,https://api.github.com/repos/pydata/xarray/issues/3475,551244548,MDEyOklzc3VlQ29tbWVudDU1MTI0NDU0OA==,5635139,2019-11-07T20:13:42Z,2019-11-07T20:13:42Z,MEMBER,"Going to merge given @dcherian 's approval, any other follow-ups I can address in another PR","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,515662368
https://github.com/pydata/xarray/pull/3475#issuecomment-551185004,https://api.github.com/repos/pydata/xarray/issues/3475,551185004,MDEyOklzc3VlQ29tbWVudDU1MTE4NTAwNA==,5635139,2019-11-07T17:36:42Z,2019-11-07T17:36:42Z,MEMBER,"This is ready to go!
As a reminder, we have `PendingDeprecationWarning` for `drop`, which is ignored in user code by default. It does appear in tests, so let me know if that's too strong given the above discussion on backward-compat.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,515662368
https://github.com/pydata/xarray/pull/3475#issuecomment-550516099,https://api.github.com/repos/pydata/xarray/issues/3475,550516099,MDEyOklzc3VlQ29tbWVudDU1MDUxNjA5OQ==,2448579,2019-11-06T21:49:43Z,2019-11-06T21:49:43Z,MEMBER,:+1:,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,515662368
https://github.com/pydata/xarray/pull/3475#issuecomment-550499576,https://api.github.com/repos/pydata/xarray/issues/3475,550499576,MDEyOklzc3VlQ29tbWVudDU1MDQ5OTU3Ng==,1217238,2019-11-06T21:04:12Z,2019-11-06T21:04:12Z,MEMBER,"I wanted a name that is reminiscent of ""sel"" in some way.
On Wed, Nov 6, 2019 at 7:14 AM Deepak Cherian
wrote:
> Add drop_sel for dropping labels
>
> Would drop_labels be better?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> ,
> or unsubscribe
>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,515662368
https://github.com/pydata/xarray/pull/3475#issuecomment-550499180,https://api.github.com/repos/pydata/xarray/issues/3475,550499180,MDEyOklzc3VlQ29tbWVudDU1MDQ5OTE4MA==,5635139,2019-11-06T21:03:07Z,2019-11-06T21:03:07Z,MEMBER,"> Would `drop_labels` be better?
I think either is reasonable. `drop_sel` has the advantage that it's easily comparable to `sel`, and has the same arguments, so I'd marginally vote for that. Am easily swayed by popular opinion!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,515662368
https://github.com/pydata/xarray/pull/3475#issuecomment-550355126,https://api.github.com/repos/pydata/xarray/issues/3475,550355126,MDEyOklzc3VlQ29tbWVudDU1MDM1NTEyNg==,2448579,2019-11-06T15:14:46Z,2019-11-06T15:14:46Z,MEMBER,"> Add drop_sel for dropping labels
Would `drop_labels` be better?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,515662368
https://github.com/pydata/xarray/pull/3475#issuecomment-550086071,https://api.github.com/repos/pydata/xarray/issues/3475,550086071,MDEyOklzc3VlQ29tbWVudDU1MDA4NjA3MQ==,5635139,2019-11-06T00:29:42Z,2019-11-06T00:29:42Z,MEMBER,"@crusaderky let me know if you know off-hand why the `MinimumVersionsPolicy` is breaking, otherwise I can look into it","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,515662368
https://github.com/pydata/xarray/pull/3475#issuecomment-550083850,https://api.github.com/repos/pydata/xarray/issues/3475,550083850,MDEyOklzc3VlQ29tbWVudDU1MDA4Mzg1MA==,5635139,2019-11-06T00:20:12Z,2019-11-06T00:20:12Z,MEMBER,"Updated! I used `PendingDeprecationWarning`, which is default disabled.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,515662368
https://github.com/pydata/xarray/pull/3475#issuecomment-549655830,https://api.github.com/repos/pydata/xarray/issues/3475,549655830,MDEyOklzc3VlQ29tbWVudDU0OTY1NTgzMA==,5635139,2019-11-05T04:15:05Z,2019-11-05T04:15:05Z,MEMBER,"Yes, that sounds reasonable—I think we move documentation and internal usages to `drop_sel` and `drop_vars`, and leave `drop` as a backward compatible option?
Maybe at last a case for `FutureDeprecationWarning` :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,515662368
https://github.com/pydata/xarray/pull/3475#issuecomment-549628677,https://api.github.com/repos/pydata/xarray/issues/3475,549628677,MDEyOklzc3VlQ29tbWVudDU0OTYyODY3Nw==,1217238,2019-11-05T01:55:38Z,2019-11-05T01:55:38Z,MEMBER,"What do you think about this alternative?
- Add `drop_sel` for dropping labels
- Add `drop_vars` for variables.
- Keep around `drop` as an overloaded alias for both?
(I'm not really sure which is best, to be honest. But keeping down churn does seem like a good idea, if possible.)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,515662368