html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3447#issuecomment-552104640,https://api.github.com/repos/pydata/xarray/issues/3447,552104640,MDEyOklzc3VlQ29tbWVudDU1MjEwNDY0MA==,14808389,2019-11-09T14:17:44Z,2019-11-09T14:17:44Z,MEMBER,"I think we need to review most if not all tests once we try to make them pass, right now there are too many errors (mostly from pint) to know if they actually do what they should.","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,512564022
https://github.com/pydata/xarray/pull/3447#issuecomment-552096649,https://api.github.com/repos/pydata/xarray/issues/3447,552096649,MDEyOklzc3VlQ29tbWVudDU1MjA5NjY0OQ==,14808389,2019-11-09T12:43:17Z,2019-11-09T12:43:17Z,MEMBER,"thanks, @max-sixty","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,512564022
https://github.com/pydata/xarray/pull/3447#issuecomment-552064856,https://api.github.com/repos/pydata/xarray/issues/3447,552064856,MDEyOklzc3VlQ29tbWVudDU1MjA2NDg1Ng==,5635139,2019-11-09T04:21:23Z,2019-11-09T04:21:23Z,MEMBER,"Great @keewis . As above, I haven't looked through all (1750!!) LoC, but looks good on the code I have. Let me / us know if there's anything you want us to look into more. 

Thank you v much!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,512564022
https://github.com/pydata/xarray/pull/3447#issuecomment-551933045,https://api.github.com/repos/pydata/xarray/issues/3447,551933045,MDEyOklzc3VlQ29tbWVudDU1MTkzMzA0NQ==,14808389,2019-11-08T18:10:37Z,2019-11-08T18:10:37Z,MEMBER,Is there anything left to do before this is ready to merge? I'd like to use some of the changes to the helper functions made here in #3493.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,512564022
https://github.com/pydata/xarray/pull/3447#issuecomment-548128979,https://api.github.com/repos/pydata/xarray/issues/3447,548128979,MDEyOklzc3VlQ29tbWVudDU0ODEyODk3OQ==,5635139,2019-10-30T21:53:52Z,2019-10-30T21:53:52Z,MEMBER,"> I think they at least partially test the same code: if two `DataArray` objects that get passed to the `Dataset` constructor as data variables have the same dimensions / coordinates, they get merged. I think that happens even if the values of the dims / coords are equal.

Ah great, because merge happens in a dataset's init, yes. Let's keep both tests though","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,512564022
https://github.com/pydata/xarray/pull/3447#issuecomment-548113449,https://api.github.com/repos/pydata/xarray/issues/3447,548113449,MDEyOklzc3VlQ29tbWVudDU0ODExMzQ0OQ==,14808389,2019-10-30T21:09:17Z,2019-10-30T21:09:17Z,MEMBER,"I think they at least partially test the same code: if two `DataArray` objects that get passed to the `Dataset` constructor as data variables have the same dimensions / coordinates, they get merged. I think that happens even if the values of the dims / coords are equal.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,512564022
https://github.com/pydata/xarray/pull/3447#issuecomment-548110891,https://api.github.com/repos/pydata/xarray/issues/3447,548110891,MDEyOklzc3VlQ29tbWVudDU0ODExMDg5MQ==,5635139,2019-10-30T21:02:08Z,2019-10-30T21:02:08Z,MEMBER,"Looks really good. I spent 20 mins looking through and looks very thorough. I didn't read through every function. Let me know if there are any other ones you want someone to look through 

> I am especially interested in comments on `Dataset.__init__` and `Dataset.test_merge`, since at the moment they seem to test the same code.

I had a good look through these. (though I didn't fully understand re 'test the same code', they seem to test the relevant init / merge functions?)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,512564022
https://github.com/pydata/xarray/pull/3447#issuecomment-548096875,https://api.github.com/repos/pydata/xarray/issues/3447,548096875,MDEyOklzc3VlQ29tbWVudDU0ODA5Njg3NQ==,14808389,2019-10-30T20:25:11Z,2019-10-30T20:25:11Z,MEMBER,"I think this is ready for review and merge. I am especially interested in comments on `Dataset.__init__` and `Dataset.test_merge`, since at the moment they seem to test the same code.

There is still a lot to do, and I will also have to go over all tests (`DataArray` and `Dataset`) to remove any obvious mistakes (I found a lot from the code in #3238), but if there are any that are not so obvious, they probably won't be found until someone works on making the tests pass.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,512564022