html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/3433#issuecomment-545829813,https://api.github.com/repos/pydata/xarray/issues/3433,545829813,MDEyOklzc3VlQ29tbWVudDU0NTgyOTgxMw==,167802,2019-10-24T09:23:14Z,2019-10-24T09:23:14Z,CONTRIBUTOR,"Ok, then I probably won't have the time to dig into this for now, sorry. If someone else with better knowledge of the code can work on this it would probably be for the best.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510892578
https://github.com/pydata/xarray/issues/3433#issuecomment-545648580,https://api.github.com/repos/pydata/xarray/issues/3433,545648580,MDEyOklzc3VlQ29tbWVudDU0NTY0ODU4MA==,2448579,2019-10-23T21:41:53Z,2019-10-23T21:41:53Z,MEMBER,"I don't think so. You'll have to check which functions are used to inject methods on groupby, resample and rolling objects (at least)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510892578
https://github.com/pydata/xarray/issues/3433#issuecomment-545303756,https://api.github.com/repos/pydata/xarray/issues/3433,545303756,MDEyOklzc3VlQ29tbWVudDU0NTMwMzc1Ng==,167802,2019-10-23T07:12:22Z,2019-10-23T07:13:22Z,CONTRIBUTOR,"ooh, maybe I answered too fast. I hadn't really looked at the code yet... but let's see:
if I understand correctly, in the function you cited, the functions get wrapped and include in the current `cls`. So I would need to fix the wrapper itself (`_func_slash_method_wrapper`) so that the attrs get copied and applied to the resulting array (if `keep_attrs` is `True` that is). However, do we have a guarantee that the wrapped functions are actually returning something that can have a `.attrs` ?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510892578
https://github.com/pydata/xarray/issues/3433#issuecomment-545295063,https://api.github.com/repos/pydata/xarray/issues/3433,545295063,MDEyOklzc3VlQ29tbWVudDU0NTI5NTA2Mw==,167802,2019-10-23T06:47:00Z,2019-10-23T06:47:00Z,CONTRIBUTOR,"Sure! What do you reckon the default should be ? False for backwards compatibility ?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510892578
https://github.com/pydata/xarray/issues/3433#issuecomment-545156537,https://api.github.com/repos/pydata/xarray/issues/3433,545156537,MDEyOklzc3VlQ29tbWVudDU0NTE1NjUzNw==,2448579,2019-10-22T21:09:05Z,2019-10-22T21:09:05Z,MEMBER,"Thanks @mraspaud 

`clip` and other injected functions need to be updated to obey `keep_attrs` (also see https://github.com/pydata/xarray/issues/3348)

https://github.com/pydata/xarray/blob/72be873857a0a56659c905ce491ca1f94b44fd5c/xarray/core/ops.py#L321-L349

Are you up for sending in a PR?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510892578