html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3375#issuecomment-539237559,https://api.github.com/repos/pydata/xarray/issues/3375,539237559,MDEyOklzc3VlQ29tbWVudDUzOTIzNzU1OQ==,6213168,2019-10-07T22:51:09Z,2019-10-07T22:51:09Z,MEMBER,"> Would you be willing to add a few of these cases to the benchmarks?

Yes, in due time. It's out of scope for this PR though.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,503163130
https://github.com/pydata/xarray/pull/3375#issuecomment-539204236,https://api.github.com/repos/pydata/xarray/issues/3375,539204236,MDEyOklzc3VlQ29tbWVudDUzOTIwNDIzNg==,2443309,2019-10-07T21:06:09Z,2019-10-07T21:06:09Z,MEMBER,"> On first sight, it's a good start, but it's missing some important use cases:
> 
> * DataArray slicing
> * slicing when there are no IndexVariables
> * no benchmarks for `.sel()`

Would you be willing to add a few of these cases to the benchmarks?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,503163130
https://github.com/pydata/xarray/pull/3375#issuecomment-538910300,https://api.github.com/repos/pydata/xarray/issues/3375,538910300,MDEyOklzc3VlQ29tbWVudDUzODkxMDMwMA==,6213168,2019-10-07T09:13:07Z,2019-10-07T09:13:51Z,MEMBER,"I see that all tests in benchmarks/indexing.py use arrays with 2~6 million points.
While this is important to spot any case where the numpy underlying functions start being unnecessarily called more than once, it also means any performance improvement or degradation in any of the pure-Python code will be completely drowned out.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,503163130
https://github.com/pydata/xarray/pull/3375#issuecomment-538906863,https://api.github.com/repos/pydata/xarray/issues/3375,538906863,MDEyOklzc3VlQ29tbWVudDUzODkwNjg2Mw==,6213168,2019-10-07T09:04:04Z,2019-10-07T09:08:12Z,MEMBER,"@jhamman hm. I'm looking at it now for the first time.
On first sight, it's a good start, but it's missing some important use cases:

- DataArray slicing
- slicing when there are no IndexVariables
- no benchmarks for ``.sel()``","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,503163130
https://github.com/pydata/xarray/pull/3375#issuecomment-538846251,https://api.github.com/repos/pydata/xarray/issues/3375,538846251,MDEyOklzc3VlQ29tbWVudDUzODg0NjI1MQ==,2443309,2019-10-07T05:34:58Z,2019-10-07T05:34:58Z,MEMBER,Thanks @crusaderky. Do you think the indexing benchmarks we have in https://github.com/pydata/xarray/blob/master/asv_bench/benchmarks/indexing.py are sufficient? Anything you think would be worth adding to cover performance regressions here?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,503163130