html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/3349#issuecomment-581584469,https://api.github.com/repos/pydata/xarray/issues/3349,581584469,MDEyOklzc3VlQ29tbWVudDU4MTU4NDQ2OQ==,20629530,2020-02-03T19:43:53Z,2020-02-03T19:43:53Z,CONTRIBUTOR,"I pushed a new PR trying to implement polyfit in xarray, #3733. It is still work in progress, but I would like the opinion on those who participated in this thread.

Considering all options discussed in the thread, I chose an implementation that seemed to give the best performance and generality (skipping NaN values), but it duplicates a lot of code from `numpy.polyfit`.

Main question: 

- Should xarray's implementation really replicate the behaviour of numpy's? 

A lot of extra code could be removed if we'd say we only want to compute and return the residuals and the coefficients. All the other variables are a few lines of code away for the user that really wants them, and they don't need the power of xarray and dask anyway.

I'm guessing @huard  @dcherian @rabernat and @shoyer  might have comments.","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,499477363