html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3340#issuecomment-534815773,https://api.github.com/repos/pydata/xarray/issues/3340,534815773,MDEyOklzc3VlQ29tbWVudDUzNDgxNTc3Mw==,1217238,2019-09-25T01:50:07Z,2019-09-25T01:50:07Z,MEMBER,"thank you, for tackling this!

On Tue, Sep 24, 2019 at 6:41 PM crusaderky <notifications@github.com> wrote:

> Thanks all!
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pydata/xarray/pull/3340?email_source=notifications&email_token=AAJJFVRB6JRRJHAZD7L3T23QLK6TBA5CNFSM4I2FKFWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7QJ3MQ#issuecomment-534814130>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAJJFVRQURJOP6IAVQWGMR3QLK6TBANCNFSM4I2FKFWA>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,497945632
https://github.com/pydata/xarray/pull/3340#issuecomment-534814130,https://api.github.com/repos/pydata/xarray/issues/3340,534814130,MDEyOklzc3VlQ29tbWVudDUzNDgxNDEzMA==,6213168,2019-09-25T01:41:03Z,2019-09-25T01:41:03Z,MEMBER,Thanks all!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,497945632
https://github.com/pydata/xarray/pull/3340#issuecomment-534804650,https://api.github.com/repos/pydata/xarray/issues/3340,534804650,MDEyOklzc3VlQ29tbWVudDUzNDgwNDY1MA==,1217238,2019-09-25T00:56:03Z,2019-09-25T00:56:03Z,MEMBER,"This looks great to me!

@crusaderky when you're ready, feel free to merge","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,497945632
https://github.com/pydata/xarray/pull/3340#issuecomment-534785445,https://api.github.com/repos/pydata/xarray/issues/3340,534785445,MDEyOklzc3VlQ29tbWVudDUzNDc4NTQ0NQ==,6213168,2019-09-24T23:22:43Z,2019-09-24T23:22:43Z,MEMBER,Ready for review,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,497945632
https://github.com/pydata/xarray/pull/3340#issuecomment-534770767,https://api.github.com/repos/pydata/xarray/issues/3340,534770767,MDEyOklzc3VlQ29tbWVudDUzNDc3MDc2Nw==,6213168,2019-09-24T22:17:50Z,2019-09-24T22:33:33Z,MEMBER,"Differences between the requirements files after the changes:

```patch
--- py36.yml
+++ py37.yml
@@ -5 +5 @@
-  - python=3.6
+  - python=3.7

--- py37.yml
+++ py37-windows.yml
@@ -9,2 +9,2 @@
-  - cdms2
-  - cfgrib>=0.9.2
+  # - cdms2  # Not available on Windows
+  # - cfgrib>=0.9.2  # Causes Python interpreter crash on Windows
@@ -31 +31 @@
-  - pynio
+  # - pynio  # Not available on Windows

```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,497945632
https://github.com/pydata/xarray/pull/3340#issuecomment-534773407,https://api.github.com/repos/pydata/xarray/issues/3340,534773407,MDEyOklzc3VlQ29tbWVudDUzNDc3MzQwNw==,6213168,2019-09-24T22:29:06Z,2019-09-24T22:29:06Z,MEMBER,@rabernat I'll look into it but on first inspection it feels like scope creep to me and I think it should be dealt with separately. Note how I didn't touch ``doc/environment.yml``.,"{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,497945632
https://github.com/pydata/xarray/pull/3340#issuecomment-534772064,https://api.github.com/repos/pydata/xarray/issues/3340,534772064,MDEyOklzc3VlQ29tbWVudDUzNDc3MjA2NA==,1197350,2019-09-24T22:23:09Z,2019-09-24T22:23:09Z,MEMBER,"For this PR, it could be worth considering the doc built challenges we are discussing over in https://github.com/pydata/xarray/pull/3199#issuecomment-534702846.

In that case, the doc build succeeded on CI but still failed on RTD. In theory, that shouldn't be possible.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,497945632