html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/3304#issuecomment-530962306,https://api.github.com/repos/pydata/xarray/issues/3304,530962306,MDEyOklzc3VlQ29tbWVudDUzMDk2MjMwNg==,81219,2019-09-12T19:04:09Z,2019-09-12T19:04:09Z,CONTRIBUTOR,"Ok, I'll submit a PR shortly. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492966281 https://github.com/pydata/xarray/issues/3304#issuecomment-530961910,https://api.github.com/repos/pydata/xarray/issues/3304,530961910,MDEyOklzc3VlQ29tbWVudDUzMDk2MTkxMA==,1217238,2019-09-12T19:02:55Z,2019-09-12T19:02:55Z,MEMBER,"> My understanding is that Variable.quantile should have a `keep_attrs` argument, correct ? Yes, this makes sense to me.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492966281 https://github.com/pydata/xarray/issues/3304#issuecomment-530960436,https://api.github.com/repos/pydata/xarray/issues/3304,530960436,MDEyOklzc3VlQ29tbWVudDUzMDk2MDQzNg==,81219,2019-09-12T18:58:58Z,2019-09-12T18:58:58Z,CONTRIBUTOR,"Looking at the code, I'm confused. The DataArray.quantile method creates a temporary dataset, copies the variable over, calls the Variable.quantile method, then assigns the attributes from the dataset to this new variable. At no point however are attributes assigned to this temporary dataset. My understanding is that Variable.quantile should have a `keep_attrs` argument, correct ?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492966281