html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3260#issuecomment-524963950,https://api.github.com/repos/pydata/xarray/issues/3260,524963950,MDEyOklzc3VlQ29tbWVudDUyNDk2Mzk1MA==,1217238,2019-08-26T18:02:36Z,2019-08-26T18:02:36Z,MEMBER,"Yes, `ds.update()` should *always* be inplace.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484778823
https://github.com/pydata/xarray/pull/3260#issuecomment-524963547,https://api.github.com/repos/pydata/xarray/issues/3260,524963547,MDEyOklzc3VlQ29tbWVudDUyNDk2MzU0Nw==,5635139,2019-08-26T18:01:37Z,2019-08-26T18:01:37Z,MEMBER,"> Could we make `_check_inplace()` entirely non-assigning? e.g., `inplace = _check_inplace(inplace)` -> `_check_inplace(inplace)`?

Yes, good idea.

Currently `ds.update(inplace=[True|False])` will raise, by default it'll be `True`, is that OK?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484778823
https://github.com/pydata/xarray/pull/3260#issuecomment-524961804,https://api.github.com/repos/pydata/xarray/issues/3260,524961804,MDEyOklzc3VlQ29tbWVudDUyNDk2MTgwNA==,1217238,2019-08-26T17:57:35Z,2019-08-26T17:57:35Z,MEMBER,"Could we make `_check_inplace()` entirely non-assigning? e.g., `inplace = _check_inplace(inplace)` -> `_check_inplace(inplace)`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484778823
https://github.com/pydata/xarray/pull/3260#issuecomment-524670484,https://api.github.com/repos/pydata/xarray/issues/3260,524670484,MDEyOklzc3VlQ29tbWVudDUyNDY3MDQ4NA==,5635139,2019-08-25T22:42:49Z,2019-08-25T22:42:49Z,MEMBER,"All done, unless anyone has thoughts re `inplace`","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484778823
https://github.com/pydata/xarray/pull/3260#issuecomment-524650833,https://api.github.com/repos/pydata/xarray/issues/3260,524650833,MDEyOklzc3VlQ29tbWVudDUyNDY1MDgzMw==,5635139,2019-08-25T18:00:30Z,2019-08-25T18:00:30Z,MEMBER,Great - what are your thoughts on `.inplace` @shoyer ?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484778823