html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3250#issuecomment-526578185,https://api.github.com/repos/pydata/xarray/issues/3250,526578185,MDEyOklzc3VlQ29tbWVudDUyNjU3ODE4NQ==,6213168,2019-08-30T12:13:25Z,2019-08-30T12:13:25Z,MEMBER,👍,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484499801
https://github.com/pydata/xarray/pull/3250#issuecomment-526087372,https://api.github.com/repos/pydata/xarray/issues/3250,526087372,MDEyOklzc3VlQ29tbWVudDUyNjA4NzM3Mg==,6213168,2019-08-29T08:40:57Z,2019-08-29T08:40:57Z,MEMBER,Ready for merge if there are no additional comments,"{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484499801
https://github.com/pydata/xarray/pull/3250#issuecomment-525253967,https://api.github.com/repos/pydata/xarray/issues/3250,525253967,MDEyOklzc3VlQ29tbWVudDUyNTI1Mzk2Nw==,6213168,2019-08-27T11:09:02Z,2019-08-27T11:13:37Z,MEMBER,"Python 3.7:
```python

In [1]: class A(xarray.DataArray): 
   ...:     pass 
   ...:                                                                                                                                                                                                                                                        
miniconda3/envs/xarray-py37/bin/ipython:1: FutureWarning: xarray subclass A should explicitly define __slots__

In [2]: a = A()                                                                                                                                                                                                                                                

In [3]: a.x = 1                                                                                                                                                                                                                                                
miniconda3/envs/xarray-py37/bin/ipython:1: FutureWarning: Setting attribute 'x' on a 'A' object. Explicitly define __slots__ to suppress this warning for legitimate custom attributes and raise an error when attempting variables assignments.

In [4]: a.x                                                                                                                                                                                                                                                   
Out[4]: 1

In [5]: a.__dict__                                                                                                                                                                                                                                             
Out[5]: {'x': 1}
```

Python 3.5: Same, but without the first FutureWarning.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484499801
https://github.com/pydata/xarray/pull/3250#issuecomment-525253062,https://api.github.com/repos/pydata/xarray/issues/3250,525253062,MDEyOklzc3VlQ29tbWVudDUyNTI1MzA2Mg==,6213168,2019-08-27T11:05:40Z,2019-08-27T11:05:40Z,MEMBER,Added automated unit tests for the automated check on ``__slots__`` for all objects inside the xarray library. I could not find a straightforward way to automatically test that objects defined outside of the library log FutureWarning instead - I tested it by hand.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484499801
https://github.com/pydata/xarray/pull/3250#issuecomment-525242799,https://api.github.com/repos/pydata/xarray/issues/3250,525242799,MDEyOklzc3VlQ29tbWVudDUyNTI0Mjc5OQ==,6213168,2019-08-27T10:32:42Z,2019-08-27T10:32:42Z,MEMBER,"@shoyer this is theoretically done, however the design I had to come up with to preserve the current statefulness of user-defined accessors displeases me and I'd rather clean it up. See #3268 for design decision.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484499801
https://github.com/pydata/xarray/pull/3250#issuecomment-524455456,https://api.github.com/repos/pydata/xarray/issues/3250,524455456,MDEyOklzc3VlQ29tbWVudDUyNDQ1NTQ1Ng==,6213168,2019-08-23T20:42:04Z,2019-08-23T20:42:04Z,MEMBER,@max-sixty any package that for any reason expects xarray objects to have a ``__dict__`` will break overnight. Any package that subclasses from xarray will get a warning. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484499801