html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3220#issuecomment-525588616,https://api.github.com/repos/pydata/xarray/issues/3220,525588616,MDEyOklzc3VlQ29tbWVudDUyNTU4ODYxNg==,6063709,2019-08-28T05:20:40Z,2019-08-28T05:20:40Z,CONTRIBUTOR,"Thanks @shoyer. I have added a test. It contains no assertion, but does fail with
```
AttributeError: 'Array' object has no attribute 'tolist'
```
without the code update. Is that sufficient?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,481005183
https://github.com/pydata/xarray/pull/3220#issuecomment-525543137,https://api.github.com/repos/pydata/xarray/issues/3220,525543137,MDEyOklzc3VlQ29tbWVudDUyNTU0MzEzNw==,6063709,2019-08-28T01:15:25Z,2019-08-28T01:15:25Z,CONTRIBUTOR,"I can save the decoded version to a file and read it back in and it throws the error. I suppose this is traversing a different code path
```
>>> xarray.decode_cf(xarray.Dataset.from_dict(ds.to_dict()))
<xarray.Dataset>
Dimensions:     (time: 5)
Coordinates:
  * time        (time) object 2198-07-02 12:00:00 ... 2202-07-02 12:00:00
Data variables:
    average_T1  (time) datetime64[ns] ...
>>> xarray.decode_cf(xarray.Dataset.from_dict(ds.to_dict())).to_netcdf('tmp.nc')
>>> xarray.decode_cf(xarray.open_mfdataset('tmp.nc',decode_cf=False))
Traceback (most recent call last):
  File ""<stdin>"", line 1, in <module>
  File ""/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/conventions.py"", line 479, in decode_cf
    decode_coords, drop_variables=drop_variables, use_cftime=use_cftime)
  File ""/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/conventions.py"", line 401, in decode_cf_variables
    stack_char_dim=stack_char_dim, use_cftime=use_cftime)
  File ""/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/conventions.py"", line 306, in decode_cf_variable
    var = coder.decode(var, name=name)
  File ""/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/coding/times.py"", line 419, in decode
    self.use_cftime)
  File ""/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/coding/times.py"", line 90, in _decode_cf_datetime_dtype
    last_item(values) or [0]])
  File ""/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/core/formatting.py"", line 99, in last_item
    return np.ravel(array[indexer]).tolist()
AttributeError: 'Array' object has no attribute 'tolist'
>>> 
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,481005183
https://github.com/pydata/xarray/pull/3220#issuecomment-525538937,https://api.github.com/repos/pydata/xarray/issues/3220,525538937,MDEyOklzc3VlQ29tbWVudDUyNTUzODkzNw==,6063709,2019-08-28T00:53:53Z,2019-08-28T00:53:53Z,CONTRIBUTOR,"HI @max-sixty. I am working on making a test, but when I serialise my test file so it is suitable for inclusion in a test it doesn't throw an error!
```
>>> ds = xarray.open_mfdataset('temp_049.nc', decode_cf=False)
>>> xarray.decode_cf(ds)
Traceback (most recent call last):
  File ""<stdin>"", line 1, in <module>
  File ""/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/conventions.py"", line 479, in decode_cf
    decode_coords, drop_variables=drop_variables, use_cftime=use_cftime)
  File ""/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/conventions.py"", line 401, in decode_cf_variables
    stack_char_dim=stack_char_dim, use_cftime=use_cftime)
  File ""/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/conventions.py"", line 306, in decode_cf_variable
    var = coder.decode(var, name=name)
  File ""/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/coding/times.py"", line 419, in decode
    self.use_cftime)
  File ""/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/coding/times.py"", line 90, in _decode_cf_datetime_dtype
    last_item(values) or [0]])
  File ""/g/data3/hh5/public/apps/miniconda3/envs/analysis3-19.07/lib/python3.6/site-packages/xarray/core/formatting.py"", line 99, in last_item
    return np.ravel(array[indexer]).tolist()
AttributeError: 'Array' object has no attribute 'tolist'
>>> xarray.decode_cf(xarray.Dataset.from_dict(ds.to_dict()))
<xarray.Dataset>
Dimensions:     (time: 5)
Coordinates:
  * time        (time) object 2198-07-02 12:00:00 ... 2202-07-02 12:00:00
Data variables:
    average_T1  (time) datetime64[ns] ...
>>> ds.identical(xarray.Dataset.from_dict(ds.to_dict()))
True
>>>
```
Seems `Dataset.identical` is failing to find something that traversing `decode_cf` does. Odd.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,481005183