html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3194#issuecomment-519762313,https://api.github.com/repos/pydata/xarray/issues/3194,519762313,MDEyOklzc3VlQ29tbWVudDUxOTc2MjMxMw==,5635139,2019-08-09T03:20:51Z,2019-08-09T03:20:51Z,MEMBER,Nice! That's quite a list. Between us there's an xkcd or narkoz reference...,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,478690528
https://github.com/pydata/xarray/pull/3194#issuecomment-519760729,https://api.github.com/repos/pydata/xarray/issues/3194,519760729,MDEyOklzc3VlQ29tbWVudDUxOTc2MDcyOQ==,12229877,2019-08-09T03:10:37Z,2019-08-09T03:10:37Z,CONTRIBUTOR,"[My config](https://github.com/Zac-HD/hypothesmith/blob/master/tox.ini) uses `tox` and `bash` instead of pre-commit.  Doesn't work well for Windows, but it's a tiny Python script to glob for .py files and `subprocess.run` the pyupgrade command.  Balancing powerful CI against new-contributor-friendliness is hard!

```ini
[testenv:check]
deps =
    -r requirements.txt
whitelist_externals = bash
commands =
    autoflake --recursive --in-place --remove-all-unused-imports --remove-duplicate-keys --remove-unused-variables .
    bash -c \""pyupgrade --py36-plus **.py\""
    isort --recursive --apply .
    black .
    flake8
    mypy --config-file=tox.ini . src/
    bandit --recursive --exclude=./.tox/** --skip=B101,B110,B310 --quiet .
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,478690528
https://github.com/pydata/xarray/pull/3194#issuecomment-519756232,https://api.github.com/repos/pydata/xarray/issues/3194,519756232,MDEyOklzc3VlQ29tbWVudDUxOTc1NjIzMg==,5635139,2019-08-09T02:43:01Z,2019-08-09T02:43:01Z,MEMBER,"One addendum: if `pre-commit` gained widespread use, and new contributors were installing and learning about it early, I would definitely be up for loading that up with checks","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,478690528
https://github.com/pydata/xarray/pull/3194#issuecomment-519750994,https://api.github.com/repos/pydata/xarray/issues/3194,519750994,MDEyOklzc3VlQ29tbWVudDUxOTc1MDk5NA==,5635139,2019-08-09T02:12:32Z,2019-08-09T02:23:11Z,MEMBER,"I think `pre-commit` is great, but that it's too much burden to compel new contributors to use by adding its effects to CI checks. 
I think we've been fairly successful recently at having some less technical folks contribute; keen not to erect even small barriers.

We could add this to `pre-commit` but _not_ to CI; there'd be some unrelated changes in PRs though.

If anyone is up for a side project - a tool that submits PRs whenever someone commits non-idiomatic code!

Open minded as ever though","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,478690528
https://github.com/pydata/xarray/pull/3194#issuecomment-519720166,https://api.github.com/repos/pydata/xarray/issues/3194,519720166,MDEyOklzc3VlQ29tbWVudDUxOTcyMDE2Ng==,12229877,2019-08-08T23:14:19Z,2019-08-08T23:14:19Z,CONTRIBUTOR,"The author pushes pre-commit pretty hard, but that shouldn't be a problem for Xarray as we're already using it. Then `pre-commit run --all-files` will execute it. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,478690528
https://github.com/pydata/xarray/pull/3194#issuecomment-519717598,https://api.github.com/repos/pydata/xarray/issues/3194,519717598,MDEyOklzc3VlQ29tbWVudDUxOTcxNzU5OA==,5635139,2019-08-08T23:01:32Z,2019-08-08T23:01:32Z,MEMBER,"We did run it through! https://github.com/pydata/xarray/pull/3190

But not with the `--py3-only` it seems... We could do that in this PR

One reason not to enforce it - I can't seem to work out how to apply it to all files in a repo - am I missing something basic? Or does it need another process to loop over files?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,478690528
https://github.com/pydata/xarray/pull/3194#issuecomment-519713454,https://api.github.com/repos/pydata/xarray/issues/3194,519713454,MDEyOklzc3VlQ29tbWVudDUxOTcxMzQ1NA==,12229877,2019-08-08T22:42:12Z,2019-08-08T22:42:12Z,CONTRIBUTOR,"In all seriousness, pyupgrade will do this and more automatically with the --py3-only option.  I'd add it to CI! ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,478690528