html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3130#issuecomment-511916643,https://api.github.com/repos/pydata/xarray/issues/3130,511916643,MDEyOklzc3VlQ29tbWVudDUxMTkxNjY0Mw==,1217238,2019-07-16T17:43:57Z,2019-07-16T17:43:57Z,MEMBER,thanks @DavidMertz and @dcherian !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467897998
https://github.com/pydata/xarray/pull/3130#issuecomment-511245920,https://api.github.com/repos/pydata/xarray/issues/3130,511245920,MDEyOklzc3VlQ29tbWVudDUxMTI0NTkyMA==,22429695,2019-07-15T00:00:06Z,2019-07-15T14:47:51Z,NONE,"# [Codecov](https://codecov.io/gh/pydata/xarray/pull/3130?src=pr&el=h1) Report
> Merging [#3130](https://codecov.io/gh/pydata/xarray/pull/3130?src=pr&el=desc) into [master](https://codecov.io/gh/pydata/xarray/commit/9438390da9ecafc2601a7f06c9e4f87637b456df?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
```diff
@@ Coverage Diff @@
## master #3130 +/- ##
==========================================
- Coverage 95.99% 95.71% -0.29%
==========================================
Files 63 63
Lines 12799 12799
==========================================
- Hits 12287 12250 -37
- Misses 512 549 +37
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467897998
https://github.com/pydata/xarray/pull/3130#issuecomment-511245138,https://api.github.com/repos/pydata/xarray/issues/3130,511245138,MDEyOklzc3VlQ29tbWVudDUxMTI0NTEzOA==,24736507,2019-07-14T23:45:36Z,2019-07-15T14:37:23Z,NONE,"Hello @DavidMertz! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
##### Comment last updated at 2019-07-15 14:37:22 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467897998
https://github.com/pydata/xarray/pull/3130#issuecomment-511251879,https://api.github.com/repos/pydata/xarray/issues/3130,511251879,MDEyOklzc3VlQ29tbWVudDUxMTI1MTg3OQ==,2448579,2019-07-15T01:20:21Z,2019-07-15T01:20:21Z,MEMBER,"Thanks for catching that @DavidMertz. Can you add back the original, simpler test too? This one is really just testing align. You could use `@pytest.mark.parametrize` to provide two different sets of `arr1, arr2` arguments.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467897998
https://github.com/pydata/xarray/pull/3130#issuecomment-511250197,https://api.github.com/repos/pydata/xarray/issues/3130,511250197,MDEyOklzc3VlQ29tbWVudDUxMTI1MDE5Nw==,2380665,2019-07-15T01:00:09Z,2019-07-15T01:00:39Z,CONTRIBUTOR,"Made changes suggested by @dcherian. This resolves the detected bug in the test. If CI passes, this should be ready to merge. Removed the temporary method `.broadcast_like_naive()` and the test using it.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467897998
https://github.com/pydata/xarray/pull/3130#issuecomment-511247968,https://api.github.com/repos/pydata/xarray/issues/3130,511247968,MDEyOklzc3VlQ29tbWVudDUxMTI0Nzk2OA==,2448579,2019-07-15T00:29:33Z,2019-07-15T00:32:02Z,MEMBER,"Thanks @DavidMertz
Line 2042 of dataset.py should be
`return _broadcast_helper(args[1], exclude, dims_map, common_coords)` i.e. `args[1]` instead of `self`.
Can you make that change (and the same change in dataarray.py, Line 1019)?
EDIT: I made the dataarray change directly.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467897998