html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3128#issuecomment-522387948,https://api.github.com/repos/pydata/xarray/issues/3128,522387948,MDEyOklzc3VlQ29tbWVudDUyMjM4Nzk0OA==,5635139,2019-08-19T02:24:00Z,2019-08-19T02:24:00Z,MEMBER,"I think the easiest way forward is to do a follow-up PR, no need to revert.
Reverting would be helpful if we wanted to _undo_ these changes - in this case we have some v marginal additional changes.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-522359045,https://api.github.com/repos/pydata/xarray/issues/3128,522359045,MDEyOklzc3VlQ29tbWVudDUyMjM1OTA0NQ==,1217238,2019-08-18T21:53:08Z,2019-08-18T21:53:08Z,MEMBER,"My (limited) understanding of how github handles reverting is that you'll still need to make a new pull request to apply your edits either way. There is no more going to back to amend after PR is merges. The only difference is what the state of ""master"" looks like when you make your new pull request (whether it includes your partial changes or not).
So I don't think it particularly matters if you revert first (as long as the forward fix happens relatively soon), but if you'd prefer to do it that way that's totally fine -- let me know and I will do it.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-522358352,https://api.github.com/repos/pydata/xarray/issues/3128,522358352,MDEyOklzc3VlQ29tbWVudDUyMjM1ODM1Mg==,2818208,2019-08-18T21:43:57Z,2019-08-18T21:43:57Z,CONTRIBUTOR,"Happy to make these changes, but what's the protocol here? Seems like reverting the merge and letting me amend is cleaner than me creating a new PR.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-522354720,https://api.github.com/repos/pydata/xarray/issues/3128,522354720,MDEyOklzc3VlQ29tbWVudDUyMjM1NDcyMA==,1217238,2019-08-18T20:56:29Z,2019-08-18T20:56:29Z,MEMBER,Post merge reviews are totally fine. It is not a big deal to revert a merge if needed.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-522353874,https://api.github.com/repos/pydata/xarray/issues/3128,522353874,MDEyOklzc3VlQ29tbWVudDUyMjM1Mzg3NA==,5635139,2019-08-18T20:43:55Z,2019-08-18T20:43:55Z,MEMBER,"@shoyer thanks for the follow-up comments. I probably should have spotted those myself.
But given there'll be points I miss, lmk if I should be waiting longer / raising specific points before hitting the big green button, or these post-merge reviews are OK. I can ensure they're complete before a release.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-522341108,https://api.github.com/repos/pydata/xarray/issues/3128,522341108,MDEyOklzc3VlQ29tbWVudDUyMjM0MTEwOA==,5635139,2019-08-18T17:42:54Z,2019-08-18T17:42:54Z,MEMBER,Great @gwgundersen !,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-522299373,https://api.github.com/repos/pydata/xarray/issues/3128,522299373,MDEyOklzc3VlQ29tbWVudDUyMjI5OTM3Mw==,2818208,2019-08-18T07:42:58Z,2019-08-18T07:42:58Z,CONTRIBUTOR,"@max-sixty, done.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-521905156,https://api.github.com/repos/pydata/xarray/issues/3128,521905156,MDEyOklzc3VlQ29tbWVudDUyMTkwNTE1Ng==,24736507,2019-08-16T06:46:32Z,2019-08-18T07:25:58Z,NONE,"Hello @gwgundersen! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
##### Comment last updated at 2019-08-18 07:25:58 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-522278593,https://api.github.com/repos/pydata/xarray/issues/3128,522278593,MDEyOklzc3VlQ29tbWVudDUyMjI3ODU5Mw==,5635139,2019-08-17T23:43:20Z,2019-08-17T23:43:20Z,MEMBER,@gwgundersen could we add a whatsnew too?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-522275521,https://api.github.com/repos/pydata/xarray/issues/3128,522275521,MDEyOklzc3VlQ29tbWVudDUyMjI3NTUyMQ==,2818208,2019-08-17T22:34:21Z,2019-08-17T22:34:21Z,CONTRIBUTOR,"Sorry for the back-and-forth. CI tests and checks are all passing, and this is ready for another review.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-522248198,https://api.github.com/repos/pydata/xarray/issues/3128,522248198,MDEyOklzc3VlQ29tbWVudDUyMjI0ODE5OA==,5635139,2019-08-17T15:42:10Z,2019-08-17T15:42:10Z,MEMBER,"I see the docs timing out after 60 min. I also see that message, but is that causing the failure?
I restarted the docs build to see whether that might help","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-522241417,https://api.github.com/repos/pydata/xarray/issues/3128,522241417,MDEyOklzc3VlQ29tbWVudDUyMjI0MTQxNw==,2448579,2019-08-17T14:21:27Z,2019-08-17T14:21:27Z,MEMBER,It looks like you've added a warming for this case. So you'll need to specify :okwarning: . ,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-522225177,https://api.github.com/repos/pydata/xarray/issues/3128,522225177,MDEyOklzc3VlQ29tbWVudDUyMjIyNTE3Nw==,2818208,2019-08-17T10:22:58Z,2019-08-17T10:22:58Z,CONTRIBUTOR,"Now the docs don't build. When I try to build locally, I get a vague error:
```bash
File ""/Users/gwg/miniconda3/envs/xarray-docs/lib/python3.7/site-packages/IPython/sphinxext/ipython_directive.py"", line 583, in process_input
raise RuntimeError('Non Expected warning in `{}` line {}'.format(filename, lineno))
RuntimeError: Non Expected warning in `/Users/gwg/projects/xarray/doc/indexing.rst` line 241
```
Do you see anything wrong with this?
```rest
The :py:meth:`~xarray.Dataset.drop` method returns a new object with the listed
index labels along a dimension dropped:
.. ipython:: python
ds.drop(['IN', 'IL'], dim='space')
<-- line 241
``drop`` is both a ``Dataset`` and ``DataArray`` method.
Use :py:meth:`~xarray.Dataset.drop_dims` to drop a full dimension from a Dataset.
Any variables with these dimensions are also dropped:
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-522057416,https://api.github.com/repos/pydata/xarray/issues/3128,522057416,MDEyOklzc3VlQ29tbWVudDUyMjA1NzQxNg==,5635139,2019-08-16T15:50:06Z,2019-08-16T15:50:06Z,MEMBER,"Thanks @gwgundersen - good idea re the cherry pick for more discrete changes.
Still getting a test failure though, check it out and lmk if you need any help","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-521908280,https://api.github.com/repos/pydata/xarray/issues/3128,521908280,MDEyOklzc3VlQ29tbWVudDUyMTkwODI4MA==,2818208,2019-08-16T07:00:37Z,2019-08-16T07:00:37Z,CONTRIBUTOR,Sorry about that. I'm not sure what happened. I've reverted branch and cherry picked my changes. The issue with `drop` being a duplicated name still stands.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-511221636,https://api.github.com/repos/pydata/xarray/issues/3128,511221636,MDEyOklzc3VlQ29tbWVudDUxMTIyMTYzNg==,22429695,2019-07-14T17:39:13Z,2019-08-16T06:51:52Z,NONE,"# [Codecov](https://codecov.io/gh/pydata/xarray/pull/3128?src=pr&el=h1) Report
> Merging [#3128](https://codecov.io/gh/pydata/xarray/pull/3128?src=pr&el=desc) into [master](https://codecov.io/gh/pydata/xarray/commit/af982800f6560c5373cb2fba16188c5143c8bb08?src=pr&el=desc) will **increase** coverage by `0.31%`.
> The diff coverage is `92.85%`.
```diff
@@ Coverage Diff @@
## master #3128 +/- ##
==========================================
+ Coverage 95.66% 95.98% +0.31%
==========================================
Files 64 63 -1
Lines 13117 12788 -329
==========================================
- Hits 12548 12274 -274
+ Misses 569 514 -55
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-521828045,https://api.github.com/repos/pydata/xarray/issues/3128,521828045,MDEyOklzc3VlQ29tbWVudDUyMTgyODA0NQ==,5635139,2019-08-15T23:08:42Z,2019-08-15T23:08:42Z,MEMBER,"@gwgundersen Could you force-push your latest code?
If your current latest code is pushed, you may have to `git reset --hard` and start again - unfortunately it looks like your PR is proposing ` +24,439 −17,647 ` changes","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-521819936,https://api.github.com/repos/pydata/xarray/issues/3128,521819936,MDEyOklzc3VlQ29tbWVudDUyMTgxOTkzNg==,2818208,2019-08-15T22:29:36Z,2019-08-15T22:29:36Z,CONTRIBUTOR,"@max-sixty, thanks! It's useful to be able to do in advance.
After merging from master, I get this error:
```
flake8
./xarray/core/dataset.py:3466:5: F811 redefinition of unused 'drop' from line 3460
```
I assume this is due to https://github.com/pydata/xarray/pull/3177 cc @crusaderky. Is there a way to avoid this?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-521818408,https://api.github.com/repos/pydata/xarray/issues/3128,521818408,MDEyOklzc3VlQ29tbWVudDUyMTgxODQwOA==,5635139,2019-08-15T22:23:07Z,2019-08-15T22:23:07Z,MEMBER,@gwgundersen I see you trying to merge re the recent black changes. Here are the instructions for making this (relatively) seamless: https://github.com/pydata/xarray/blob/d3f1ced1aa84cb0a0f3e47e7ee67492e203fcce5/doc/contributing.rst#code-formatting,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659
https://github.com/pydata/xarray/pull/3128#issuecomment-511229790,https://api.github.com/repos/pydata/xarray/issues/3128,511229790,MDEyOklzc3VlQ29tbWVudDUxMTIyOTc5MA==,1217238,2019-07-14T19:41:38Z,2019-07-14T19:41:38Z,MEMBER,"Awesome, thanks for working on this @gwgundersen !
In the long term, we might want to deprecate the current function signature, but I'm happy to leave that for later.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467865659