html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/3127#issuecomment-511232700,https://api.github.com/repos/pydata/xarray/issues/3127,511232700,MDEyOklzc3VlQ29tbWVudDUxMTIzMjcwMA==,1217238,2019-07-14T20:25:35Z,2019-07-14T20:25:35Z,MEMBER,"OK, I just merged https://github.com/pydata/xarray/pull/3086 in master. I would suggest either merging `master` into this PR branch, or (probably easier) making a new branch from master with your improved docs/tests.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467862319 https://github.com/pydata/xarray/pull/3127#issuecomment-511232692,https://api.github.com/repos/pydata/xarray/issues/3127,511232692,MDEyOklzc3VlQ29tbWVudDUxMTIzMjY5Mg==,2380665,2019-07-14T20:25:27Z,2019-07-14T20:25:27Z,CONTRIBUTOR,Great. Will do.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467862319 https://github.com/pydata/xarray/pull/3127#issuecomment-511232392,https://api.github.com/repos/pydata/xarray/issues/3127,511232392,MDEyOklzc3VlQ29tbWVudDUxMTIzMjM5Mg==,1217238,2019-07-14T20:20:54Z,2019-07-14T20:20:54Z,MEMBER,"I think I'm going to merge the other PR, then you can fork off of master again and add your doc/test improvements?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467862319 https://github.com/pydata/xarray/pull/3127#issuecomment-511232137,https://api.github.com/repos/pydata/xarray/issues/3127,511232137,MDEyOklzc3VlQ29tbWVudDUxMTIzMjEzNw==,2380665,2019-07-14T20:17:22Z,2019-07-14T20:17:22Z,CONTRIBUTOR,"I realized the overlap only after I made the PR. Their implementation of factoring out the shared code is better than my simple wrapper. But my documention and tests are better. What's the best way to merge the best? I'm happy to do it, but not sure if it should be a new branch and PR, or a revision of one of the existing ones.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467862319 https://github.com/pydata/xarray/pull/3127#issuecomment-511229439,https://api.github.com/repos/pydata/xarray/issues/3127,511229439,MDEyOklzc3VlQ29tbWVudDUxMTIyOTQzOQ==,1217238,2019-07-14T19:36:31Z,2019-07-14T19:36:31Z,MEMBER,"Hi @DavidMertz -- @dcherian already started working on this over in https://github.com/pydata/xarray/pull/3086. But there's probably something useful that could be combined between these pull requests, maybe some of the docs or tests?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467862319 https://github.com/pydata/xarray/pull/3127#issuecomment-511219191,https://api.github.com/repos/pydata/xarray/issues/3127,511219191,MDEyOklzc3VlQ29tbWVudDUxMTIxOTE5MQ==,22429695,2019-07-14T17:05:28Z,2019-07-14T17:17:05Z,NONE,"# [Codecov](https://codecov.io/gh/pydata/xarray/pull/3127?src=pr&el=h1) Report > Merging [#3127](https://codecov.io/gh/pydata/xarray/pull/3127?src=pr&el=desc) into [master](https://codecov.io/gh/pydata/xarray/commit/4cbe635488a16c133cb22bc50c13c89cd3607e38?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `88.88%`. ```diff @@ Coverage Diff @@ ## master #3127 +/- ## ========================================== + Coverage 95.98% 95.99% +0.01% ========================================== Files 63 63 Lines 12777 12784 +7 ========================================== + Hits 12264 12272 +8 + Misses 513 512 -1 ``` ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467862319 https://github.com/pydata/xarray/pull/3127#issuecomment-511219382,https://api.github.com/repos/pydata/xarray/issues/3127,511219382,MDEyOklzc3VlQ29tbWVudDUxMTIxOTM4Mg==,2380665,2019-07-14T17:08:15Z,2019-07-14T17:08:15Z,CONTRIBUTOR,"This was branched off of https://github.com/pydata/xarray/pull/3127 by mistake. If both are merged, no issue.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467862319