html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/3116#issuecomment-524375694,https://api.github.com/repos/pydata/xarray/issues/3116,524375694,MDEyOklzc3VlQ29tbWVudDUyNDM3NTY5NA==,2599958,2019-08-23T16:18:04Z,2019-08-23T16:18:04Z,NONE,"I was wondering why the checksum kept failing. I'm glad that it's fixed now. On Fri, Aug 23, 2019 at 9:11 AM Deepak Cherian wrote: > It looks awesome! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , > or mute the thread > > . > -- Prof. Rob Hetland Texas A&M Univ. – Dept. of Oceanography http://pong.tamu.edu/~rob ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-524373465,https://api.github.com/repos/pydata/xarray/issues/3116,524373465,MDEyOklzc3VlQ29tbWVudDUyNDM3MzQ2NQ==,2448579,2019-08-23T16:11:06Z,2019-08-23T16:11:06Z,MEMBER,It looks awesome!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-524342860,https://api.github.com/repos/pydata/xarray/issues/3116,524342860,MDEyOklzc3VlQ29tbWVudDUyNDM0Mjg2MA==,1197350,2019-08-23T14:45:13Z,2019-08-23T14:45:13Z,MEMBER,"I finally got the page to build and it looks great! http://xarray.pydata.org/en/scipy19-docs/examples/ROMS_ocean_model.html There was an issue with the ROMS MD5 checksum which I fixed in https://github.com/pydata/xarray-data/pull/17. The checksums .md5 files cannot have newlines at the end.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-517650108,https://api.github.com/repos/pydata/xarray/issues/3116,517650108,MDEyOklzc3VlQ29tbWVudDUxNzY1MDEwOA==,1197350,2019-08-02T10:24:50Z,2019-08-23T14:44:01Z,MEMBER,"I am returning to this after some vacation. Thanks so much @hetland for this great example! The test failures are not related to this PR. I see only three things that need to be done to get this ready to merge. - [x] Add a short introductory paragraph at the very top of the notebook with some very general backgroud. Remember we have users from tons of different fields (e.g. finance, bioinformatics); they will have no idea what ROMS stands for or even what an ocean model is. We need a few sentences to introduce this example and explain what it shows (primarily how to visualize data that has irregular / derived coordinate geometry) - [x] Remove or resolve the commented-out code in the example. - [x] Add credit to @hetland in `whats-new.rst` ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-522024714,https://api.github.com/repos/pydata/xarray/issues/3116,522024714,MDEyOklzc3VlQ29tbWVudDUyMjAyNDcxNA==,1197350,2019-08-16T14:16:22Z,2019-08-16T14:16:22Z,MEMBER,Thanks for this @hetland! I'm going to merge now!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-511155955,https://api.github.com/repos/pydata/xarray/issues/3116,511155955,MDEyOklzc3VlQ29tbWVudDUxMTE1NTk1NQ==,22429695,2019-07-13T21:45:15Z,2019-08-02T19:50:29Z,NONE,"# [Codecov](https://codecov.io/gh/pydata/xarray/pull/3116?src=pr&el=h1) Report > Merging [#3116](https://codecov.io/gh/pydata/xarray/pull/3116?src=pr&el=desc) into [scipy19-docs](https://codecov.io/gh/pydata/xarray/commit/92cd3c4ef9fc61c62fe8c8d257dd223c73a80ac2?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. ```diff @@ Coverage Diff @@ ## scipy19-docs #3116 +/- ## ================================================ + Coverage 95.99% 95.99% +<.01% ================================================ Files 63 63 Lines 12796 12799 +3 ================================================ + Hits 12284 12287 +3 Misses 512 512 ``` ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-517819281,https://api.github.com/repos/pydata/xarray/issues/3116,517819281,MDEyOklzc3VlQ29tbWVudDUxNzgxOTI4MQ==,2599958,2019-08-02T19:32:34Z,2019-08-02T19:32:34Z,NONE,"Hopefully these changes are all done now. I added my credit to 'Enhancements' instead of 'New functions/methods'; hope I guessed right. I didn't see any other examples of notebooks added. On Fri, Aug 2, 2019 at 5:24 AM Ryan Abernathey wrote: > I am returning to this after some vacation. Thanks so much @hetland > > for this great example! > > The test failures are not related to this PR. I see only three things that > need to be done to get this ready to merge. > > - Add a short introductory paragraph at the very top of the notebook > with some very general backgroud. Remember we have users from tons of > different fields (e.g. finance, bioinformatics); they will have no idea > what ROMS stands for or even what an ocean model is. We need a few > sentences to introduce this example and explain what it shows (primarily > how to visualize data that has irregular / derived coordinate geometry) > - Remove or resolve the commented-out code in the example. > - Add credit to @hetland > > in whats-new.rst > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , > or mute the thread > > . > -- Prof. Rob Hetland Texas A&M Univ. – Dept. of Oceanography http://pong.tamu.edu/~rob ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-511937974,https://api.github.com/repos/pydata/xarray/issues/3116,511937974,MDEyOklzc3VlQ29tbWVudDUxMTkzNzk3NA==,2599958,2019-07-16T18:43:34Z,2019-07-16T18:43:34Z,NONE,"OK, I closed the other pull request, and updated this branch.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-511538753,https://api.github.com/repos/pydata/xarray/issues/3116,511538753,MDEyOklzc3VlQ29tbWVudDUxMTUzODc1Mw==,1197350,2019-07-15T19:33:14Z,2019-07-15T19:33:14Z,MEMBER,I just saw the new PR (#3134). You don't need to start a new PR unless something is truly broken here. You can just keep pushing to this one.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-511536815,https://api.github.com/repos/pydata/xarray/issues/3116,511536815,MDEyOklzc3VlQ29tbWVudDUxMTUzNjgxNQ==,1197350,2019-07-15T19:26:58Z,2019-07-15T19:26:58Z,MEMBER,"You have to rebase your feature branch on the upstream/scipy19-docs branch in order to get #3121 to work locally. ``` git fetch upstream git rebase upstream/scipy19-docs ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-511536283,https://api.github.com/repos/pydata/xarray/issues/3116,511536283,MDEyOklzc3VlQ29tbWVudDUxMTUzNjI4Mw==,1197350,2019-07-15T19:25:22Z,2019-07-15T19:25:22Z,MEMBER,Can you post the error and stack trace?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-511536035,https://api.github.com/repos/pydata/xarray/issues/3116,511536035,MDEyOklzc3VlQ29tbWVudDUxMTUzNjAzNQ==,2599958,2019-07-15T19:24:33Z,2019-07-15T19:24:33Z,NONE,"I'm having a hard time getting the docs to compile, they fail when loading the `ROMS_example.nc` file, though I switched to `xr.tutorial.open_dataset('ROMS_example.nc')`. Is there something else I need to do? I pushed a revised version.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-511260768,https://api.github.com/repos/pydata/xarray/issues/3116,511260768,MDEyOklzc3VlQ29tbWVudDUxMTI2MDc2OA==,2599958,2019-07-15T02:48:44Z,2019-07-15T02:48:44Z,NONE,"I'll try to get this done very soon. On Sun, Jul 14, 2019 at 8:33 PM Ryan Abernathey wrote: > @hetland > > - thanks so much for this! Now that pydata/xarray-data#13 > > has been merged, can you try to update your example to use the > xr.tutorial.open_dataset('ROMS_example.nc') function? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , > or mute the thread > > . > -- Prof. Rob Hetland Texas A&M Univ. – Dept. of Oceanography http://pong.tamu.edu/~rob ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201 https://github.com/pydata/xarray/pull/3116#issuecomment-511253099,https://api.github.com/repos/pydata/xarray/issues/3116,511253099,MDEyOklzc3VlQ29tbWVudDUxMTI1MzA5OQ==,1197350,2019-07-15T01:33:30Z,2019-07-15T01:33:30Z,MEMBER,"@hetland - thanks so much for this! Now that https://github.com/pydata/xarray-data/pull/13 has been merged, can you try to update your example to use the `xr.tutorial.open_dataset('ROMS_example.nc')` function?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201