html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/3112#issuecomment-516952010,https://api.github.com/repos/pydata/xarray/issues/3112,516952010,MDEyOklzc3VlQ29tbWVudDUxNjk1MjAxMA==,5635139,2019-07-31T17:48:19Z,2019-07-31T17:48:19Z,MEMBER,Thanks again for the PR,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467756080 https://github.com/pydata/xarray/pull/3112#issuecomment-516951853,https://api.github.com/repos/pydata/xarray/issues/3112,516951853,MDEyOklzc3VlQ29tbWVudDUxNjk1MTg1Mw==,5635139,2019-07-31T17:47:56Z,2019-07-31T17:47:56Z,MEMBER,Sorry @crusaderky - we were all waiting on each other! My mistake,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467756080 https://github.com/pydata/xarray/pull/3112#issuecomment-516920645,https://api.github.com/repos/pydata/xarray/issues/3112,516920645,MDEyOklzc3VlQ29tbWVudDUxNjkyMDY0NQ==,6213168,2019-07-31T16:21:33Z,2019-07-31T16:21:33Z,MEMBER,@max-sixty @shoyer can we merge please?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467756080 https://github.com/pydata/xarray/pull/3112#issuecomment-511508383,https://api.github.com/repos/pydata/xarray/issues/3112,511508383,MDEyOklzc3VlQ29tbWVudDUxMTUwODM4Mw==,24736507,2019-07-15T18:04:37Z,2019-07-24T22:54:48Z,NONE,"Hello @crusaderky! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: ##### Comment last updated at 2019-07-24 22:54:48 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467756080 https://github.com/pydata/xarray/pull/3112#issuecomment-514800845,https://api.github.com/repos/pydata/xarray/issues/3112,514800845,MDEyOklzc3VlQ29tbWVudDUxNDgwMDg0NQ==,1217238,2019-07-24T21:08:26Z,2019-07-24T21:08:26Z,MEMBER,"+1 please go ahead without me! On Wed, Jul 24, 2019 at 9:53 AM Maximilian Roos wrote: > Thanks @crusaderky ! I think fine to > merge given we've both reviewed > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , > or mute the thread > > . > ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467756080 https://github.com/pydata/xarray/pull/3112#issuecomment-514713355,https://api.github.com/repos/pydata/xarray/issues/3112,514713355,MDEyOklzc3VlQ29tbWVudDUxNDcxMzM1NQ==,5635139,2019-07-24T16:53:39Z,2019-07-24T16:53:39Z,MEMBER,Thanks @crusaderky ! I think fine to merge given we've both reviewed,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467756080 https://github.com/pydata/xarray/pull/3112#issuecomment-514552299,https://api.github.com/repos/pydata/xarray/issues/3112,514552299,MDEyOklzc3VlQ29tbWVudDUxNDU1MjI5OQ==,6213168,2019-07-24T09:20:35Z,2019-07-24T09:20:35Z,MEMBER,@shoyer this is ready for merge unless there are comments,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467756080 https://github.com/pydata/xarray/pull/3112#issuecomment-511147066,https://api.github.com/repos/pydata/xarray/issues/3112,511147066,MDEyOklzc3VlQ29tbWVudDUxMTE0NzA2Ng==,22429695,2019-07-13T19:17:00Z,2019-07-19T09:24:47Z,NONE,"# [Codecov](https://codecov.io/gh/pydata/xarray/pull/3112?src=pr&el=h1) Report > Merging [#3112](https://codecov.io/gh/pydata/xarray/pull/3112?src=pr&el=desc) into [master](https://codecov.io/gh/pydata/xarray/commit/9afe4d0cc1c5bee68a3e28887125a31336e4f58f?src=pr&el=desc) will **decrease** coverage by `0.04%`. > The diff coverage is `88.57%`. ```diff @@ Coverage Diff @@ ## master #3112 +/- ## ========================================== - Coverage 95.98% 95.94% -0.05% ========================================== Files 63 63 Lines 12802 12816 +14 ========================================== + Hits 12288 12296 +8 - Misses 514 520 +6 ``` ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467756080 https://github.com/pydata/xarray/pull/3112#issuecomment-511528707,https://api.github.com/repos/pydata/xarray/issues/3112,511528707,MDEyOklzc3VlQ29tbWVudDUxMTUyODcwNw==,5635139,2019-07-15T19:02:20Z,2019-07-15T19:02:20Z,MEMBER,"Great! Agree re `Optional`, thanks for clearing up. Good to go from my end","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467756080 https://github.com/pydata/xarray/pull/3112#issuecomment-511231279,https://api.github.com/repos/pydata/xarray/issues/3112,511231279,MDEyOklzc3VlQ29tbWVudDUxMTIzMTI3OQ==,6213168,2019-07-14T20:05:41Z,2019-07-14T20:05:41Z,MEMBER,@shoyer @max-sixty ready for review and merge,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467756080