html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/3092#issuecomment-519711789,https://api.github.com/repos/pydata/xarray/issues/3092,519711789,MDEyOklzc3VlQ29tbWVudDUxOTcxMTc4OQ==,5635139,2019-08-08T22:34:53Z,2019-08-08T22:34:53Z,MEMBER,Thanks @Zac-HD ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687 https://github.com/pydata/xarray/issues/3092#issuecomment-511553442,https://api.github.com/repos/pydata/xarray/issues/3092,511553442,MDEyOklzc3VlQ29tbWVudDUxMTU1MzQ0Mg==,5635139,2019-07-15T20:17:40Z,2019-07-15T20:18:03Z,MEMBER,"> I didn't know about isort, nice. However, from a very quick test, it's not compatible with black There's a specific isort config that's compatible with black; this is what we use internally (there's a similar official version I believe): ``` [isort] default_section=THIRDPARTY force_grid_wrap=0 include_trailing_comma=True line_length=88 multi_line_output=3 use_parentheses=True ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687 https://github.com/pydata/xarray/issues/3092#issuecomment-511538661,https://api.github.com/repos/pydata/xarray/issues/3092,511538661,MDEyOklzc3VlQ29tbWVudDUxMTUzODY2MQ==,5635139,2019-07-15T19:32:54Z,2019-07-15T19:32:54Z,MEMBER,"@shoyer great TODOs (please add where I've missed) - [ ] Reformat code - [ ] CI checks - [ ] Short instructions for how to merge an existing PR (i.e. avoid manual merge resolution) - [ ] Black badge - [ ] Do we want to keep `flake8` checks? Black is mostly stricter but not always, e.g. on lines at the end of files. (+0.3 from me to use only `black` and stop using `flake8`) - [ ] Do we want to include `isort`? (-0.1 from me, even though I like the tool)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687 https://github.com/pydata/xarray/issues/3092#issuecomment-511439980,https://api.github.com/repos/pydata/xarray/issues/3092,511439980,MDEyOklzc3VlQ29tbWVudDUxMTQzOTk4MA==,5635139,2019-07-15T15:03:22Z,2019-07-15T15:03:22Z,MEMBER,I'm happy to do this today,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687 https://github.com/pydata/xarray/issues/3092#issuecomment-510525639,https://api.github.com/repos/pydata/xarray/issues/3092,510525639,MDEyOklzc3VlQ29tbWVudDUxMDUyNTYzOQ==,5635139,2019-07-11T15:06:53Z,2019-07-11T15:06:53Z,MEMBER,"I would be v keen. I find it _great_. But I'm generally too keen on a) tools and b) changing everything at once, so I discount myself a bit here! I don't think it's possible to apply incrementally, unfortunately (e.g. only on changed lines). So it would require a single sweeping change. Interested to know how other projects are handling. IIRC they're applying it to some parts of stdlib too.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687