html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/3092#issuecomment-519711789,https://api.github.com/repos/pydata/xarray/issues/3092,519711789,MDEyOklzc3VlQ29tbWVudDUxOTcxMTc4OQ==,5635139,2019-08-08T22:34:53Z,2019-08-08T22:34:53Z,MEMBER,Thanks @Zac-HD ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-519711707,https://api.github.com/repos/pydata/xarray/issues/3092,519711707,MDEyOklzc3VlQ29tbWVudDUxOTcxMTcwNw==,12229877,2019-08-08T22:34:33Z,2019-08-08T22:34:33Z,CONTRIBUTOR,@max-sixty - closed by #3142 I think? ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-511555108,https://api.github.com/repos/pydata/xarray/issues/3092,511555108,MDEyOklzc3VlQ29tbWVudDUxMTU1NTEwOA==,6213168,2019-07-15T20:22:28Z,2019-07-15T20:22:28Z,MEMBER,"I tried your setup.cfg above but still getting inconsistencies with black when I have comments in the imports.
black:
```python
import foo
# Let me explain why we do this
import bar
```
isort:
```python
import foo
# Let me explain why we do this
import bar
```
and I strongly agree with black.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-511553442,https://api.github.com/repos/pydata/xarray/issues/3092,511553442,MDEyOklzc3VlQ29tbWVudDUxMTU1MzQ0Mg==,5635139,2019-07-15T20:17:40Z,2019-07-15T20:18:03Z,MEMBER,"> I didn't know about isort, nice. However, from a very quick test, it's not compatible with black
There's a specific isort config that's compatible with black; this is what we use internally (there's a similar official version I believe):
```
[isort]
default_section=THIRDPARTY
force_grid_wrap=0
include_trailing_comma=True
line_length=88
multi_line_output=3
use_parentheses=True
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-511552648,https://api.github.com/repos/pydata/xarray/issues/3092,511552648,MDEyOklzc3VlQ29tbWVudDUxMTU1MjY0OA==,6213168,2019-07-15T20:15:28Z,2019-07-15T20:15:28Z,MEMBER,"I just ran isort on my own project.
Overall, it gave me a bunch of good suggestions, but the amount of times I twitched my nose and manually reverted what it did are too many for my tastes.
Besides the aforementioned incompatibilities with black, I hate when it changes
```
from .. import module1
from .. import module2
```
to
```
from .. import module1, module2
```
which in my opinion flies in the face of the PEP8 rule of never importing two modules on the same line.
So my opinion is: +1 for a manually vetted one-time run; -1 for automatic integration in CI.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-511545508,https://api.github.com/repos/pydata/xarray/issues/3092,511545508,MDEyOklzc3VlQ29tbWVudDUxMTU0NTUwOA==,6213168,2019-07-15T19:54:30Z,2019-07-15T19:54:30Z,MEMBER,"flake8 is not just about formatting; none of the pyflakes errors (e.g. double/unused imports) are covered by black.
I didn't know about isort, nice. However, from a very quick test, it's not compatible with black e.g. if you run black -> isort -> black, the two tools keep touching each other's changes.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-511538661,https://api.github.com/repos/pydata/xarray/issues/3092,511538661,MDEyOklzc3VlQ29tbWVudDUxMTUzODY2MQ==,5635139,2019-07-15T19:32:54Z,2019-07-15T19:32:54Z,MEMBER,"@shoyer great
TODOs (please add where I've missed)
- [ ] Reformat code
- [ ] CI checks
- [ ] Short instructions for how to merge an existing PR (i.e. avoid manual merge resolution)
- [ ] Black badge
- [ ] Do we want to keep `flake8` checks? Black is mostly stricter but not always, e.g. on lines at the end of files. (+0.3 from me to use only `black` and stop using `flake8`)
- [ ] Do we want to include `isort`? (-0.1 from me, even though I like the tool)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-511441494,https://api.github.com/repos/pydata/xarray/issues/3092,511441494,MDEyOklzc3VlQ29tbWVudDUxMTQ0MTQ5NA==,1217238,2019-07-15T15:07:17Z,2019-07-15T15:07:17Z,MEMBER,"Let's wait a little while for the burst of activity from SciPy to die down
first.
On Mon, Jul 15, 2019 at 8:03 AM Maximilian Roos
wrote:
> I'm happy to do this today
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
>
> .
>
","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-511439980,https://api.github.com/repos/pydata/xarray/issues/3092,511439980,MDEyOklzc3VlQ29tbWVudDUxMTQzOTk4MA==,5635139,2019-07-15T15:03:22Z,2019-07-15T15:03:22Z,MEMBER,I'm happy to do this today,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-511175625,https://api.github.com/repos/pydata/xarray/issues/3092,511175625,MDEyOklzc3VlQ29tbWVudDUxMTE3NTYyNQ==,1217238,2019-07-14T05:53:29Z,2019-07-14T05:53:29Z,MEMBER,"> Since Black requires Python >=3.6, which would set the minimum Python version to 3.6 for contributing to xarray (which currently requires Python >= 3.5), are there any plans of dropping Python 3.5 support in the near future?
I don't think these decisions need to be coupled. It's OK to make contributors upgrade to a newer version of Python before all our users.
There are no immediate plans to drop Python 3.5 support, but we haven't really discussed it either. I think it would definitely make sense to drop Python 3.5 after Python 3.8 is available, maybe sooner. Four major Python versions would definitely be too many.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-511170054,https://api.github.com/repos/pydata/xarray/issues/3092,511170054,MDEyOklzc3VlQ29tbWVudDUxMTE3MDA1NA==,13301940,2019-07-14T03:28:40Z,2019-07-14T03:29:08Z,MEMBER,"Since Black requires Python >=3.6, which would set the minimum Python version to 3.6 for contributing to xarray (which currently requires Python >= 3.5), are there any plans of dropping Python 3.5 support in the near future?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-511054250,https://api.github.com/repos/pydata/xarray/issues/3092,511054250,MDEyOklzc3VlQ29tbWVudDUxMTA1NDI1MA==,1217238,2019-07-12T22:37:58Z,2019-07-12T22:38:15Z,MEMBER,"+1 from me, too.
It's definitely going to cause some nasty merge conflicts for any work in progress, but hopefully it's straightforward to fix those by running black on the PRs and then merging in master.
We should be able to simply add another job on Azure for this. The `lint` task using flake8 on Azure's pre-installed Python runs very quickly (less than 30 seconds!) and I would expect to see the same from `black`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-511038269,https://api.github.com/repos/pydata/xarray/issues/3092,511038269,MDEyOklzc3VlQ29tbWVudDUxMTAzODI2OQ==,2443309,2019-07-12T21:25:14Z,2019-07-12T21:25:14Z,MEMBER,"If we do this, which I am +1 on, we should add a pre-commit hook so we don't have to think about the manual applications. We should probably just copy the dask approach: https://github.com/dask/dask/pull/4983.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687
https://github.com/pydata/xarray/issues/3092#issuecomment-510525639,https://api.github.com/repos/pydata/xarray/issues/3092,510525639,MDEyOklzc3VlQ29tbWVudDUxMDUyNTYzOQ==,5635139,2019-07-11T15:06:53Z,2019-07-11T15:06:53Z,MEMBER,"I would be v keen. I find it _great_.
But I'm generally too keen on a) tools and b) changing everything at once, so I discount myself a bit here!
I don't think it's possible to apply incrementally, unfortunately (e.g. only on changed lines). So it would require a single sweeping change. Interested to know how other projects are handling. IIRC they're applying it to some parts of stdlib too.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687