html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/3065#issuecomment-507135502,https://api.github.com/repos/pydata/xarray/issues/3065,507135502,MDEyOklzc3VlQ29tbWVudDUwNzEzNTUwMg==,6213168,2019-07-01T06:38:54Z,2019-07-01T06:38:54Z,MEMBER,@shoyer maybe instead of percentage you can configure it to count the absolute number of lines not covered? ,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,462401539 https://github.com/pydata/xarray/pull/3065#issuecomment-507101931,https://api.github.com/repos/pydata/xarray/issues/3065,507101931,MDEyOklzc3VlQ29tbWVudDUwNzEwMTkzMQ==,5635139,2019-07-01T03:20:58Z,2019-07-01T03:20:58Z,MEMBER,Much cleaner! Thanks @crusaderky!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,462401539 https://github.com/pydata/xarray/pull/3065#issuecomment-507090258,https://api.github.com/repos/pydata/xarray/issues/3065,507090258,MDEyOklzc3VlQ29tbWVudDUwNzA5MDI1OA==,1217238,2019-07-01T02:00:23Z,2019-07-01T02:00:23Z,MEMBER,"Thanks @crusaderky. I’m going to disable the codecov status check shortly. It’s nice to see the numbers, but it definitely is not helpful to block PRs merely because they are deleting lines of code that had test coverage!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,462401539 https://github.com/pydata/xarray/pull/3065#issuecomment-507079120,https://api.github.com/repos/pydata/xarray/issues/3065,507079120,MDEyOklzc3VlQ29tbWVudDUwNzA3OTEyMA==,6213168,2019-07-01T00:14:11Z,2019-07-01T00:14:11Z,MEMBER,"@shoyer all done. The worsened coverage is caused by removing a wealth of lines, so the lines that were already being missed weight more >__>","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,462401539 https://github.com/pydata/xarray/pull/3065#issuecomment-507033543,https://api.github.com/repos/pydata/xarray/issues/3065,507033543,MDEyOklzc3VlQ29tbWVudDUwNzAzMzU0Mw==,24736507,2019-06-30T12:47:21Z,2019-06-30T23:38:14Z,NONE,"Hello @crusaderky! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: ##### Comment last updated at 2019-06-30 23:38:14 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,462401539 https://github.com/pydata/xarray/pull/3065#issuecomment-507063270,https://api.github.com/repos/pydata/xarray/issues/3065,507063270,MDEyOklzc3VlQ29tbWVudDUwNzA2MzI3MA==,22429695,2019-06-30T20:02:49Z,2019-06-30T23:38:03Z,NONE,"# [Codecov](https://codecov.io/gh/pydata/xarray/pull/3065?src=pr&el=h1) Report > Merging [#3065](https://codecov.io/gh/pydata/xarray/pull/3065?src=pr&el=desc) into [master](https://codecov.io/gh/pydata/xarray/commit/2b3489b9ac91f1567aaa94c9fdbdc8fd617cda79?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `93.65%`. [![Impacted file tree graph](https://codecov.io/gh/pydata/xarray/pull/3065/graphs/tree.svg?width=650&token=YJC0ezBozS&height=150&src=pr)](https://codecov.io/gh/pydata/xarray/pull/3065?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3065 +/- ## ========================================== - Coverage 93.81% 93.78% -0.03% ========================================== Files 68 68 Lines 13201 13156 -45 ========================================== - Hits 12384 12338 -46 - Misses 817 818 +1 ``` | [Impacted Files](https://codecov.io/gh/pydata/xarray/pull/3065?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [xarray/core/dask\_array\_compat.py](https://codecov.io/gh/pydata/xarray/pull/3065/diff?src=pr&el=tree#diff-eGFycmF5L2NvcmUvZGFza19hcnJheV9jb21wYXQucHk=) | `100% <ø> (ø)` | :arrow_up: | | [xarray/core/resample.py](https://codecov.io/gh/pydata/xarray/pull/3065/diff?src=pr&el=tree#diff-eGFycmF5L2NvcmUvcmVzYW1wbGUucHk=) | `92.95% <100%> (-0.1%)` | :arrow_down: | | [xarray/core/groupby.py](https://codecov.io/gh/pydata/xarray/pull/3065/diff?src=pr&el=tree#diff-eGFycmF5L2NvcmUvZ3JvdXBieS5weQ==) | `97.86% <100%> (-0.01%)` | :arrow_down: | | [xarray/core/alignment.py](https://codecov.io/gh/pydata/xarray/pull/3065/diff?src=pr&el=tree#diff-eGFycmF5L2NvcmUvYWxpZ25tZW50LnB5) | `97.52% <100%> (+0.45%)` | :arrow_up: | | [xarray/plot/utils.py](https://codecov.io/gh/pydata/xarray/pull/3065/diff?src=pr&el=tree#diff-eGFycmF5L3Bsb3QvdXRpbHMucHk=) | `96.41% <100%> (-0.03%)` | :arrow_down: | | [xarray/core/npcompat.py](https://codecov.io/gh/pydata/xarray/pull/3065/diff?src=pr&el=tree#diff-eGFycmF5L2NvcmUvbnBjb21wYXQucHk=) | `89.06% <100%> (+0.6%)` | :arrow_up: | | [xarray/core/nputils.py](https://codecov.io/gh/pydata/xarray/pull/3065/diff?src=pr&el=tree#diff-eGFycmF5L2NvcmUvbnB1dGlscy5weQ==) | `99.12% <100%> (ø)` | :arrow_up: | | [xarray/core/missing.py](https://codecov.io/gh/pydata/xarray/pull/3065/diff?src=pr&el=tree#diff-eGFycmF5L2NvcmUvbWlzc2luZy5weQ==) | `94.46% <100%> (+0.3%)` | :arrow_up: | | [xarray/plot/facetgrid.py](https://codecov.io/gh/pydata/xarray/pull/3065/diff?src=pr&el=tree#diff-eGFycmF5L3Bsb3QvZmFjZXRncmlkLnB5) | `96.75% <100%> (-0.08%)` | :arrow_down: | | [xarray/core/nanops.py](https://codecov.io/gh/pydata/xarray/pull/3065/diff?src=pr&el=tree#diff-eGFycmF5L2NvcmUvbmFub3BzLnB5) | `93.27% <100%> (-2.66%)` | :arrow_down: | | ... and [5 more](https://codecov.io/gh/pydata/xarray/pull/3065/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/pydata/xarray/pull/3065?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/pydata/xarray/pull/3065?src=pr&el=footer). Last update [2b3489b...74ed80e](https://codecov.io/gh/pydata/xarray/pull/3065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,462401539 https://github.com/pydata/xarray/pull/3065#issuecomment-507036451,https://api.github.com/repos/pydata/xarray/issues/3065,507036451,MDEyOklzc3VlQ29tbWVudDUwNzAzNjQ1MQ==,6213168,2019-06-30T13:27:57Z,2019-06-30T13:27:57Z,MEMBER,@shoyer ready for review and merge,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,462401539